Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix semver checks in CI #1908

Closed
wants to merge 1 commit into from
Closed

chore: fix semver checks in CI #1908

wants to merge 1 commit into from

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Feb 5, 2025

No description provided.

@doug-q doug-q requested a review from aborgna-q February 5, 2025 10:49
@doug-q doug-q requested a review from a team as a code owner February 5, 2025 10:49
@doug-q doug-q force-pushed the doug/fix-semver-llvm branch from ccfbe8d to 79228c6 Compare February 5, 2025 10:51
@hugrbot
Copy link
Collaborator

hugrbot commented Feb 5, 2025

This PR contains breaking changes to the public Rust API.
Please deprecate the old API instead (if possible), or mark the PR with a ! to indicate a breaking change.

cargo-semver-checks summary

@aborgna-q
Copy link
Collaborator

I think semver checks are working already?
https://github.com/CQCL/hugr/actions/runs/13155044605/job/36710195910

Note that workflow calls are executed in a separate runner, so installing things here won't change the runtime.
I had to add an apt-dependencies parameter to the workflow to deal with capnproto before.
https://github.com/CQCL/hugrverse-actions/blob/97c4297b1a493b5bf6827ba38b6f7d7fa4891348/.github/workflows/rs-semver-checks.yml#L11-L15

@aborgna-q
Copy link
Collaborator

Uhm. I see it failing here.

https://github.com/CQCL/hugr/actions/runs/13155673562/job/36712137197#step:10:162

Do you know why it was working before? Is this a spurious error?

@doug-q
Copy link
Collaborator Author

doug-q commented Feb 5, 2025

Uhm. I see it failing here.

https://github.com/CQCL/hugr/actions/runs/13155673562/job/36712137197#step:10:162

Do you know why it was working before? Is this a spurious error?

I think it really fails earlier:
https://github.com/CQCL/hugr/actions/runs/13155673562/job/36712137197#step:10:162

I suspect that it has been broken since the github-runner-llvm issue

@doug-q
Copy link
Collaborator Author

doug-q commented Feb 5, 2025

I think semver checks are working already? https://github.com/CQCL/hugr/actions/runs/13155044605/job/36710195910

Note that workflow calls are executed in a separate runner, so installing things here won't change the runtime. I had to add an apt-dependencies parameter to the workflow to deal with capnproto before. https://github.com/CQCL/hugrverse-actions/blob/97c4297b1a493b5bf6827ba38b6f7d7fa4891348/.github/workflows/rs-semver-checks.yml#L11-L15

Yes I agree this PR doesn't work. The best solution I can think of is to add env parameter to hugrverse-actions/rs-semver-checks, then set LLVM_SYS_140_PREFIX.

@aborgna-q
Copy link
Collaborator

See #1909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants