Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error from clippy check on CI due to deprecated remove_polyfuncs #758

Closed
cqc-alec opened this issue Jan 27, 2025 · 0 comments · Fixed by #759
Closed

Error from clippy check on CI due to deprecated remove_polyfuncs #758

cqc-alec opened this issue Jan 27, 2025 · 0 comments · Fixed by #759
Assignees
@cqc-alec

Comments

@cqc-alec
Copy link
Collaborator

The clippy check on the CI is failing: https://github.com/CQCL/tket2/actions/runs/12980837714/job/36198388971 .

The suggested fix is to use hugr::algorithms::dead_funcs::RemoveDeadFuncsPass instead, but this suggestion is incorrect (probably out of date), as RemoveDeadFuncsPass is exported by hugr_passes.

So hugr_passes needs to be added as a dependency. Even then, it seems that RemoveDeadFuncsPass is not a drop-in replacement for remove_polyfuncs (different signature).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cqc-alec cqc-alec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use RemoveDeadFuncsPass instead of deprecated remove_polyfuncs() CQCL/tket2
1 participant
@cqc-alec