Skip to content
This repository has been archived by the owner on Aug 4, 2021. It is now read-only.

bump to bump to 0.5.9 #52

Merged
merged 6 commits into from
Jan 26, 2021
Merged

bump to bump to 0.5.9 #52

merged 6 commits into from
Jan 26, 2021

Conversation

blankdots
Copy link
Contributor

@blankdots blankdots commented Jan 25, 2021

Description

Main issue with sharing tools accessing the services with correct certificates

Related issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Changes Made

  1. fix certificate verify failed
  2. use python 3.8 in docker image
  3. bump to 0.5.9
  4. catch exceptions for json decode error http status

Testing

  • Tests do not apply

Mentions

@blankdots blankdots added the bug Something isn't working label Jan 25, 2021
@blankdots blankdots self-assigned this Jan 25, 2021
teemukataja
teemukataja previously approved these changes Jan 26, 2021
Copy link
Contributor

@teemukataja teemukataja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but what if there was a response handler function which does the try-catches, because now the same try-catch is duplicated 6 times

@blankdots blankdots merged commit 2688801 into master Jan 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants