feat!: switch to metrics generator pattern #233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #225
This will allow us to add metrics in a more agile way, since this library now maintains all code to create metrics.
This is a breaking change, since now, to enable metrics, instead of passing a
IDiscv5Metrics
object in the constructor, you pass aRegistry
object (and this library constructs theIDiscv5Metrics
object)Before:
Discv5.create({..., metrics})
After:
Discv5.create({..., metricsRegistry})