Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
BIP39 seeds are used by ledger devices and hierarchical wallets. This change is backwards compatible since previously the hdpath had to be empty.
Test plan
run staking operation on main branch:
run staking operation on
ton_support_bip39_keys
branch:Config:
Now, flipping the
isBIP39
flag to true, changes the derived address to:which matches the address generated by the ton go version.
And changing the hd path to:
result in the same address that we get on the ledger device, this is: