Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L10N to the name of optional components #647

Merged

Conversation

MahBoiDeveloper
Copy link
Contributor

As MarkJFox mentioned, there is a bug where the client doesn't show the translated component name in the install message boxes. PR should fix this.

Before:

image
image

After:

Снимок экрана 2025-01-30 173133
Снимок экрана 2025-01-30 173309
Снимок экрана 2025-01-30 173426

Copy link

github-actions bot commented Jan 30, 2025

Nightly build for this pull request:

@SadPencil SadPencil changed the title Add L10N to the components in the XNAMessageBox Add L10N to the name of custom components Jan 31, 2025
@SadPencil SadPencil changed the title Add L10N to the name of custom components Add L10N to the name of optional components Jan 31, 2025
Copy link
Member

@Metadorius Metadorius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why translate every time instead of translating the source field/property once?

@MahBoiDeveloper
Copy link
Contributor Author

Why translate every time instead of translating the source field/property once?

Alternative solution is to use .L10N in CustomComponent class, but it gives error because it cannot use string extensions in ClientUpdater project and include other client's namespaces. I don't know how to fix such dependencies and decided to use simpler idea.

@Metadorius Metadorius merged commit 3c0d2e0 into CnCNet:develop Jan 31, 2025
3 checks passed
@MahBoiDeveloper MahBoiDeveloper deleted the fix-messagebox-component-naming branch January 31, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants