move common props to Directory.Build.props (#48)

* move common props to Directory.Build.props * Update Lombok.NET.csproj --------- Co-authored-by: Collin Alpert <[email protected]>
CollinAlpert · Jun 20, 2024 · e8ab51c · e8ab51c
1 parent 3a38063
commit e8ab51c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>
+<Project>
+    <PropertyGroup>
+        <ImplicitUsings>true</ImplicitUsings>
+        <Nullable>enable</Nullable>
+        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+        <LangVersion>12</LangVersion>
+    </PropertyGroup>
+</Project>
diff --git a/Lombok.NET.Test/FreezerTest.cs b/Lombok.NET.Test/FreezerTest.cs
@@ -108,7 +108,7 @@ public void TryUnfreeze_WhenNotFrozen_ReturnsFalse()
 
 file sealed class Freezer
 {
-	private string _name;
+	private string _name = null!;
 
 	public bool IsFrozen { get; private set; }
 

diff --git a/Lombok.NET.Test/Lombok.NET.Test.csproj b/Lombok.NET.Test/Lombok.NET.Test.csproj
@@ -2,7 +2,6 @@
 
     <PropertyGroup>
         <TargetFramework>net8.0</TargetFramework>
-        <ImplicitUsings>true</ImplicitUsings>
         <IsPackable>false</IsPackable>
         <EmitCompilerGeneratedFiles>true</EmitCompilerGeneratedFiles>
     </PropertyGroup>

diff --git a/Lombok.NET/Lombok.NET.csproj b/Lombok.NET/Lombok.NET.csproj
@@ -2,8 +2,6 @@
 
     <PropertyGroup>
         <TargetFramework>netstandard2.0</TargetFramework>
-        <LangVersion>10</LangVersion>
-        <Nullable>enable</Nullable>
         <PackageId>Lombok.NET</PackageId>
         <Version>2.3.1</Version>
         <Authors>Collin Alpert</Authors>
@@ -17,7 +15,6 @@
         <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
         <GenerateDocumentationFile>true</GenerateDocumentationFile>
         <NoWarn>RS2008</NoWarn>
-        <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
     </PropertyGroup>
 
     <ItemGroup>