Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix top level error wrap #55

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix top level error wrap #55

merged 1 commit into from
Aug 5, 2024

Conversation

ltitanb
Copy link
Collaborator

@ltitanb ltitanb commented Aug 5, 2024

Error in config parsing are now bubbled up to the user.

Before

Initializing Commit-Boost with config file: config.example.toml
Error: could not deserialize toml from string

Now

Initializing Commit-Boost with config file: config.example.toml
Error:
   0: could not deserialize toml from string
   1: TOML parse error at line 16, column 7
   1:    |
   1: 16 | url = "http://[email protected]"
   1:    |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   1: odd number of digits
   1:

Location:
   crates/common/src/config/utils.rs:22

@ltitanb ltitanb requested a review from fbrv August 5, 2024 15:20
@ltitanb ltitanb merged commit 7649c89 into main Aug 5, 2024
4 checks passed
@ltitanb ltitanb deleted the config-error branch August 5, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants