Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Prefix::keys return errors #774

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Fix: Prefix::keys return errors #774

merged 2 commits into from
Aug 8, 2022

Conversation

maurolacy
Copy link
Contributor

Closes #766.

@maurolacy maurolacy requested review from ueco-jb and ethanfrey August 8, 2022 09:41
ueco-jb
ueco-jb approved these changes Aug 8, 2022
View reviewed changes
Copy link
Contributor

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some simplest testcase?

@maurolacy
Copy link
Contributor Author

maurolacy commented Aug 8, 2022 •
edited
Loading

Was thinking about that, but it may be non-trivial to make deserialisation fail. Will see what I can do.

@maurolacy maurolacy force-pushed the 766-keys-never-fails branch from 4124418 to 77cd091 Compare August 8, 2022 13:49
@maurolacy maurolacy merged commit f4b7f25 into main Aug 8, 2022
@maurolacy maurolacy deleted the 766-keys-never-fails branch August 8, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

@ethanfrey ethanfrey Awaiting requested review from ethanfrey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prefix::keys method never fails
2 participants
@maurolacy @ueco-jb