-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long vol in readers #296
Long vol in readers #296
Conversation
Could yo please update de "-i" description? I'd need to have a look to the GenericReader with rescale.. |
Thanks I forget, that done ;) |
Do you know why importWithValueFunctor documentation is not visible on Dgtal http://dgtal.org/doc/nightly/structDGtal_1_1GenericReader.html ? |
@image html res3dImageViewer.png "resulting visualisation of 3d image with thresholded set of voxels." | ||
@code | ||
-h [ --help ] display this message | ||
-i [ --input ] arg vol file (.vol, .longvol .p3d, .pgm3d and if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should add something that the data will be scaled for longvol/dicom/... formats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done thanks, I continue with other tools...
otherwise it's fine. thanks;) |
I thinks it is because it not defined in all specialised template (in particular it is not defined in GenericReader< TContainer, 3, DGtal::uint64_t >DGtal). But perhaps we can add an issue to add a ref to the template specialisation. |
visualisation/3dImageViewer.cpp
Outdated
or sdp (sequence of discrete points). | ||
or sdp (sequence of discrete points). For | ||
longvol, dicom, dcm, mha or mhd formats, the | ||
input values are scaled into 0 and 255. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"are linearly scaled between 0 and 255" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes thanks ;)
@dcoeurjo could we merge ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, fine for me.. thanks
ChangeLog.md
Outdated
# DGtalTools 0.9.4 | ||
|
||
- *visualisation*: | ||
- Improve visualisation tools (3dImageViewer, sliceViewer, 3dVolViewer, vol2sdp) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update changelog
done thanks ;) |
ok thanks. merging |
PR Description
Add longvol in various readers.
In progress, todo:
Checklist
cmake
mode (otherwise, Travis C.I. will fail).