Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long vol in readers #296

Merged
merged 19 commits into from
Mar 30, 2017
Merged

Long vol in readers #296

merged 19 commits into from
Mar 30, 2017

Conversation

kerautret
Copy link
Member

@kerautret kerautret commented Mar 2, 2017

PR Description
Add longvol in various readers.
In progress, todo:

  • 3dImageViewer
  • sliceViewer
  • 3dVolViewer
  • vol2sdp
  • vol2obj
  • vol2slice
  • vol2raw
  • vol2heightfield
  • volBoundary2obj

Checklist

  • Doxygen documentation of the code completed (classes, methods, types, members...).
  • Main tool doxygen documentation (following existing documentation of DGtalTools documentation.
  • Check if it follows the tools structure described in CONTRIBUTING.md
  • New entry in the ChangeLog.md added.
  • Update the readme with potentially a screenshot of the tools if it applies.
  • No warning raised in Debug cmake mode (otherwise, Travis C.I. will fail).

@dcoeurjo
Copy link
Member

dcoeurjo commented Mar 7, 2017

Could yo please update de "-i" description?

I'd need to have a look to the GenericReader with rescale..

@kerautret
Copy link
Member Author

Thanks I forget, that done ;)

@dcoeurjo
Copy link
Member

Do you know why importWithValueFunctor documentation is not visible on Dgtal http://dgtal.org/doc/nightly/structDGtal_1_1GenericReader.html ?

@image html res3dImageViewer.png "resulting visualisation of 3d image with thresholded set of voxels."
@code
-h [ --help ] display this message
-i [ --input ] arg vol file (.vol, .longvol .p3d, .pgm3d and if
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add something that the data will be scaled for longvol/dicom/... formats

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done thanks, I continue with other tools...

@dcoeurjo
Copy link
Member

otherwise it's fine. thanks;)

@kerautret
Copy link
Member Author

I thinks it is because it not defined in all specialised template (in particular it is not defined in GenericReader< TContainer, 3, DGtal::uint64_t >DGtal). But perhaps we can add an issue to add a ref to the template specialisation.

or sdp (sequence of discrete points).
or sdp (sequence of discrete points). For
longvol, dicom, dcm, mha or mhd formats, the
input values are scaled into 0 and 255.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"are linearly scaled between 0 and 255" ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes thanks ;)

@kerautret
Copy link
Member Author

@dcoeurjo could we merge ?

Copy link
Member

@dcoeurjo dcoeurjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, fine for me.. thanks

ChangeLog.md Outdated
# DGtalTools 0.9.4

- *visualisation*:
- Improve visualisation tools (3dImageViewer, sliceViewer, 3dVolViewer, vol2sdp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update changelog

@kerautret
Copy link
Member Author

done thanks ;)

@dcoeurjo
Copy link
Member

ok thanks. merging

@dcoeurjo dcoeurjo merged commit 704d730 into DGtal-team:master Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants