-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standalone scheme face functions #1345
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a short look and already stumbled upon 2 things
…ndalone-scheme-faces
…ndalone-scheme-faces
…lone-scheme-faces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but can you comment your code a little bit more? Especially the longer/more complex face functions need more comments.
@@ -231,8 +240,7 @@ struct t8_standalone_scheme | |||
static constexpr int | |||
element_get_corner_face (const t8_element_t *element, const int corner, const int face) noexcept | |||
{ | |||
SC_ABORT ("This function is not implemented yet.\n"); | |||
return 0; | |||
return 2 * face + ((corner & (1 << face)) >> face); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return 2 * face + ((corner & (1 << face)) >> face); | |
T8_ASSERT(element_is_valid(element)); | |
return 2 * face + ((corner & (1 << face)) >> face); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The element itself is actually not needed. Can it be removed from the interface then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The element might be needed in the default scheme and can therefore not be removed from the interface here. This could be addressed in a separate Issue or PR, since a complete removal is out of scope for this PR.
Describe your changes here:
Add the face functionality for the standalone scheme.
All these boxes must be checked by the reviewers before merging the pull request:
As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.
General
The reviewer executed the new code features at least once and checked the results manually
The code follows the t8code coding guidelines
New source/header files are properly added to the Makefiles
The code is well documented
All function declarations, structs/classes and their members have a proper doxygen documentation
All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)
Tests
Github action
The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)
All tests pass (in various configurations, this should be executed automatically in a github action)
If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):
Scripts and Wiki
script/find_all_source_files.scp
to check the indentation of these files.License
doc/
(or already has one)Tag Label