Code

Rubocop - DO NOT MERGE YET#3045

Code

Merged

raycarrick-ed merged 67 commits intomasterDMPRoadmap/roadmap:masterfrom rubocopDMPRoadmap/roadmap:rubocopCopy head branch name to clipboardJan 27, 2022

+14,173-16,917

Commits

Commits on Oct 1, 2021

• updated rubocop and started editing .rubocop.yml

  briri

  committed
  4b92e19

  Copy full SHA for 4b92e19

• added rubocop-rails and rubocop-rspec

  briri

  committed
  d7243e2

  Copy full SHA for d7243e2

• added some additional rubocop helper gems

  briri

  committed
  9b13616

  Copy full SHA for 9b13616

• added some additional rubocop helper gems

  briri

  committed
  f6dfc66

  Copy full SHA for f6dfc66

• added some additional rubocop helper gems

  briri

  committed
  cf7ed3b

  Copy full SHA for cf7ed3b

Commits on Oct 4, 2021

• ran Inspecting 529 files

  Show description for 3922375
  briri

  committed
  3922375

  Copy full SHA for 3922375

Commits on Oct 5, 2021

• Remove the the hardcoded word - DMPRoadmap

  martaribeiro

  committed
  282774e

  Copy full SHA for 282774e

Commits on Oct 6, 2021

• Merge pull request #3046 from DMPRoadmap/remove_dmproadmap_from_terms

  Show description for 82cd991
  raycarrick-ed

  authored
  82cd991

  Copy full SHA for 82cd991

• Fix views and remove any check on block length

  martaribeiro

  committed
  348414e

  Copy full SHA for 348414e

Commits on Oct 8, 2021

• Translation.io tags missing

  martaribeiro

  committed
  ad551e0

  Copy full SHA for ad551e0

Commits on Oct 11, 2021

• Merge pull request #3050 from DMPRoadmap/translation_io_small_fixes

  Show description for 497229a
  briri

  authored
  497229a

  Copy full SHA for 497229a

Commits on Oct 12, 2021

• Merge pull request #3048 from DMPRoadmap/fix_rubocop_in_views

  Show description for d8345f4
  briri

  authored
  d8345f4

  Copy full SHA for d8345f4

• Merge branch 'master' into rubocop

  briri

  authored
  7a1a026

  Copy full SHA for 7a1a026

Commits on Oct 13, 2021

• Issue #629 - (DCC Bug) Fix for "Granting API use rights does not work if

  Show description for 2b481a1
  

  John Pinto

  committed
  2b481a1

  Copy full SHA for 2b481a1

• Merge branch 'development' into bug_629_granting_API_use_rights_not_working

  briri

  authored
  b09dcf0

  Copy full SHA for b09dcf0

Commits on Oct 25, 2021

• Issue #2955 - UserMailer#permissions_change_notification receives incorrect user

  Show description for 7e7e558
  

  John Pinto

  committed
  7e7e558

  Copy full SHA for 7e7e558

• Merge pull request #3052 from DMPRoadmap/bug_2955_usermailer_permissions_change_notification_receives_incorrect_user

  Show description for 06c65a0
  briri

  authored
  06c65a0

  Copy full SHA for 06c65a0

• Merge branch 'development' into bug_629_granting_API_use_rights_not_working

  briri

  authored
  825406a

  Copy full SHA for 825406a

• Merge pull request #3047 from DMPRoadmap/bug_629_granting_API_use_rights_not_working

  Show description for 69f085c
  briri

  authored
  69f085c

  Copy full SHA for 69f085c

Commits on Nov 1, 2021

• fixed rubocop for helpers

  briri

  committed
  e6dd4fe

  Copy full SHA for e6dd4fe

• fixed rubocop for mailers

  briri

  committed
  1483c63

  Copy full SHA for 1483c63

• update comment on ccontributor presenter

  briri

  committed
  d8a6e46

  Copy full SHA for d8a6e46

• fixed rubocop for services

  briri

  committed
  93e44cd

  Copy full SHA for 93e44cd

• fixed rubocop issues for models

  briri

  committed
  198e6ba

  Copy full SHA for 198e6ba

• fixed rubocop for lib

  briri

  committed
  34bac40

  Copy full SHA for 34bac40

• fixed rubocop for specs

  briri

  committed
  c63cbba

  Copy full SHA for c63cbba

Commits on Nov 3, 2021

• Issue #DCC649 - Fix for the contributor to fail to save on Contributor

  Show description for 6f30ff1
  

  John Pinto

  committed
  6f30ff1

  Copy full SHA for 6f30ff1

• Merge pull request #3060 from DMPRoadmap/bug_dcc_649-contributors_page_affiliation_not_set_prevents_save

  Show description for 43c5b03
  briri

  authored
  43c5b03

  Copy full SHA for 43c5b03

• finished up rubocop fixes

  briri

  committed
  74e0c2f

  Copy full SHA for 74e0c2f

• tweaks to changes made for rubocop to fix broken tests

  briri

  committed
  3feb121

  Copy full SHA for 3feb121

• fix additional rubocop issues

  briri

  committed
  d4e2f6c

  Copy full SHA for d4e2f6c

• updated brakeman

  briri

  committed
  34d5a80

  Copy full SHA for 34d5a80

• rubocop fix

  briri

  committed
  b76da31

  Copy full SHA for b76da31

• fix for rubocop for feature spec

  briri

  committed
  7485283

  Copy full SHA for 7485283

• fix for rubocop for feature spec

  briri

  committed
  1759f37

  Copy full SHA for 1759f37

• try to figure out how host is set for url_helpers in test

  briri

  committed
  86a6a6a

  Copy full SHA for 86a6a6a

• removed StandardError rescue_from in application_controller because it was too broad

  briri

  committed
  ece5a1b

  Copy full SHA for ece5a1b

• finished up rubocop changes and fixed broken tests

  briri

  committed
  9e252de

  Copy full SHA for 9e252de

• updated translation files to use the format instead of

  briri

  committed
  ab4aa06

  Copy full SHA for ab4aa06

Commits on Nov 8, 2021

• removed need to use single quotes in app/views

  briri

  committed
  459555e

  Copy full SHA for 459555e

Commits on Jan 12, 2022

• Merge branch 'master' into rubocop

  raycarrick-ed

  authored
  b03a24a

  Copy full SHA for b03a24a

• Update org_selectable.rb

  Show description for d517061
  raycarrick-ed

  authored
  d517061

  Copy full SHA for d517061

Commits on Jan 25, 2022

• Update MySQL version

  Show description for 9dd79ec
  raycarrick-ed

  authored
  9dd79ec

  Copy full SHA for 9dd79ec

• more rubocop fixes

  raycarrick-ed

  committed
  ea07fa8

  Copy full SHA for ea07fa8

• Merge branch 'rubocop' of github.com:DMPRoadmap/roadmap into rubocop

  raycarrick-ed

  committed
  5b4f127

  Copy full SHA for 5b4f127

• sort ownership

  raycarrick-ed

  committed
  ed7a539

  Copy full SHA for ed7a539

• Add apt-get clean

  Show description for 9d009c3
  raycarrick-ed

  authored
  9d009c3

  Copy full SHA for 9d009c3

• Explicitly add failing package

  Show description for 177b934
  raycarrick-ed

  authored
  177b934

  Copy full SHA for 177b934

• minor fix for a rubocop complaint

  briri

  committed
  2b866d9

  Copy full SHA for 2b866d9

• reverted change to mysql installation in github workflow

  briri

  committed
  06e2e62

  Copy full SHA for 06e2e62

• added change back to mysql installation in github workflow

  briri

  committed
  747845a

  Copy full SHA for 747845a

• Added another package for mysql install in github workflow

  briri

  committed
  490ded1

  Copy full SHA for 490ded1

• tweak to try and get mysql working in github workflow

  briri

  committed
  8e34bd0

  Copy full SHA for 8e34bd0

Commits on Jan 26, 2022

• Remove mysql install

  Show description for f46cc17
  raycarrick-ed

  authored
  f46cc17

  Copy full SHA for f46cc17

• Merge branch 'master' into rubocop

  raycarrick-ed

  authored
  ce780ce

  Copy full SHA for ce780ce

• Try to fix yarn

  Show description for 2109ea3
  raycarrick-ed

  authored
  2109ea3

  Copy full SHA for 2109ea3

• added step to capture node version to github workflow

  briri

  committed
  c467613

  Copy full SHA for c467613

• some changes to update our mysql github workflow

  briri

  committed
  76c1d97

  Copy full SHA for 76c1d97

• update gem and js dependencies

  briri

  committed
  119c22a

  Copy full SHA for 119c22a

• trying to update webpacker

  briri

  committed
  2d965e1

  Copy full SHA for 2d965e1

• further cleanup of the mysql github workflow

  briri

  committed
  fc6db1b

  Copy full SHA for fc6db1b

• further cleanup of the mysql github workflow

  briri

  committed
  04750bc

  Copy full SHA for 04750bc

• final cleanup for mysql github workflow - removed yarn build in favor of node build

  briri

  committed
  f628c3b

  Copy full SHA for f628c3b

• github workflow for mysql now working but failure on node post run cleanup due to issue with cache

  briri

  committed
  54a0483

  Copy full SHA for 54a0483

• updates to other github workflows to use the newer ruby and node builds

  briri

  committed
  b825d5b

  Copy full SHA for b825d5b

• fixed an issue with the plan exports controller's policcy check

  briri

  committed
  9bb023b

  Copy full SHA for 9bb023b

• removed old commented out rules from rubocop config

  briri

  committed
  9a04a68

  Copy full SHA for 9a04a68