Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the 'expand/collapse button not work on after creating multiple sections on org_admin/template section #3151

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

pengyin-shan
Copy link
Contributor

Fixes the 'expand/collapse button not work on after creating multiple sections on /org_admin/template(portagenetwork#166) .

Changes proposed in this PR:

  • add <a> to click action to make it trigger on this page (the link of expanding/collapse used to not work)
  • update corresponding behavior and bootstrap class based on this page

This is my first PR to DMPRoadmap (start from a small one haha), so I might miss something. Please let me know if you see any problems. Thank you!

@raycarrick-ed
Copy link
Contributor

Tested on our dev server; could recreate bug; this fixed it. So all good.

Copy link
Contributor

@briri briri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pengyin-shan! This looks all looks good

@briri briri merged commit 47f3e69 into DMPRoadmap:development Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants