Shuffle keys for /v1/gaen/getExposed endpoint #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Up to now for the /v1/gaen/getExposed endpoint, the order of the keys returned to the clients has been the same as the order of submitting the keys. This reveals some information that might be used to detect if somebody submitted a valid key or not. Even if it's already fixed in /v2/gaen/exposed endpoint, this PR also shuffles the keys for the /v1 endpoint. Closes #274
ineiti
force-pushed
the
shuffle_keys_v1_gaen_getExposed
branch
from
5515b93 to
c16a6a0
Compare
|
SonarCloud Quality Gate failed.
|
|
The failing code analysis seems to be on code I didn't touch... |
martinalig
approved these changes
Nov 4, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up to now for the /v1/gaen/getExposed endpoint, the order of the keys returned to the
clients has been the same as the order of submitting the keys. This reveals some
information that might be used to detect if somebody submitted a valid key or not.
Even if it's already fixed in /v2/gaen/exposed endpoint, this PR also shuffles
the keys for the /v1 endpoint.
Closes #274