Ask all installer questions upfront

[da2x]

Please change the installer to prompt for all questions upfront, and then do the time consuming task afterwards. It’s disrespectful of users’ time to have them sit and wait minutes between questions, only to have them wait several more minutes for the next one. It would also make it quicker and less burdensome for uses to set this up. (It would mean users don’t associate DShield with a time-consuming and slow installation process and are more likely to deploy more instances on other networks or repair an instance if it needs looking after.)

[gebhard73]

Sorry, but the wording of your comment is disrescpectful of all colleagues having spent and still spending their free time to make things like this happen. Of course there are many things which can be optimized, but it's not what you say but how you say it.
If you have suggestions - welcome. If you're willing to help - more than welcome. But insulting colleagues spending their free time is not acceptale for me.

[da2x]

I’m sorry, but it wasn’t my intention to insult anyone. (I’m not an native English speaker.) I identified a problem that I felt would improve the user experience and adoption, and tried to describe and justify my opinion. I sat through the installer more times than normal users would so I got a concentrated dosage of the installer slowness while working out issue #61. I left the comment in the bug tracker because I love what you guys are doing and thought my input could help benefit the project in a positive way. I do apologize for failing to communicate respectfully and adequately to accomplish this goal.

[gebhard73]

thanks, apology accepted ...
As I said, your issue is a very valid one (I remember noting it down "somewhere") and is on our wish list. We welcome feedback and reporting of issues to make the project better.

[gebhard73]

@jullrich suggstion: labes as enhancement

[Bill-Thorsteinson]

This may solve an issue I found when running install.sh --update`.

Before running the script, I modified the adminports value in /etc/dshied.ini. An appropriate ruleset.nft file was generated when running interactively. The script also added additional redundant IPs to the localips variable.

Consolidating the code that generates the configuration and skipping it when running non-interactively, may solve this issue.