urlencode '+' characters in email addresses #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: actually urlencode all characters properly.
|
Ready to merge. 👍 |
|
Thanks. Probably should find a better urlencode then just encode + and @. but this is better then before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My email address contains a perfectly valid
+character, but I wasn’t being allowed to login to the DShield client. This patch fixes it so that at least I can login.(Please note that the mailbox part of an email address even can contain an
@symbol and be a valid email address — and then we have all the international characters and issues therein too.)TOOD: actually urlencode all the things properly.