Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NDMII-3310] Provide API for any integration to become HA Integration #33578

Closed
wants to merge 15 commits into from

Conversation

jedupau
Copy link
Contributor

@jedupau jedupau commented Jan 30, 2025

What does this PR do?

This PR removes hard coded lists of possible ha integrations in favor of a new config in CommonInstanceConfig which is applied for CheckBase

Motivation

We want to let the user configure HA for all integrations and let him enable/disable for each instance
Corresponding RFC: https://datadoghq.atlassian.net/wiki/spaces/II/pages/4452254162/RFC+Support+HA+for+all+integrations

Other PRs are coming to flag integrations as HASupported or not
#33828
DataDog/integrations-core#19580

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@jedupau jedupau force-pushed the jed/enable-ha-all-integrations branch from cc832d4 to bc9326c Compare January 30, 2025 16:27
@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 30, 2025
Copy link

cit-pr-commenter bot commented Jan 30, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 659f7a8a-cd73-46f5-91cd-d186d2376c99

Baseline: 16bfa4f
Comparison: 970c555
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +0.82 [+0.76, +0.89] 1 Logs
quality_gate_logs % cpu utilization +0.24 [-2.80, +3.29] 1 Logs
file_tree memory utilization +0.12 [+0.05, +0.18] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.83, +0.94] 1 Logs
quality_gate_idle_all_features memory utilization +0.03 [-0.04, +0.10] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http2 egress throughput +0.02 [-0.88, +0.91] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.85, +0.85] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.28, +0.27] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.00 [-0.79, +0.79] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.01 [-0.48, +0.45] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.02 [-0.66, +0.61] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.74, +0.68] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.35 [-1.21, +0.50] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.41 [-1.18, +0.35] 1 Logs
quality_gate_idle memory utilization -0.46 [-0.52, -0.39] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@jedupau jedupau force-pushed the jed/enable-ha-all-integrations branch from c60bebc to f40903a Compare January 31, 2025 09:50
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 31, 2025

Uncompressed package size comparison

Comparison with ancestor 16bfa4fdf67f4c67a45582c254d1bef347dd1757

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.01MB ⚠️ 873.70MB 873.69MB 0.50MB
datadog-heroku-agent-amd64-deb 0.01MB ⚠️ 446.09MB 446.07MB 0.50MB
datadog-agent-x86_64-rpm 0.01MB ⚠️ 883.44MB 883.43MB 0.50MB
datadog-agent-x86_64-suse 0.01MB ⚠️ 883.44MB 883.43MB 0.50MB
datadog-agent-arm64-deb 0.01MB ⚠️ 861.58MB 861.57MB 0.50MB
datadog-agent-aarch64-rpm 0.01MB ⚠️ 871.30MB 871.29MB 0.50MB
datadog-iot-agent-amd64-deb 0.01MB ⚠️ 86.50MB 86.49MB 0.50MB
datadog-iot-agent-arm64-deb 0.01MB ⚠️ 82.77MB 82.77MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.01MB ⚠️ 82.84MB 82.84MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.01MB ⚠️ 86.57MB 86.56MB 0.50MB
datadog-iot-agent-x86_64-suse 0.01MB ⚠️ 86.57MB 86.56MB 0.50MB
datadog-dogstatsd-x86_64-rpm -0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-x86_64-suse -0.00MB 59.18MB 59.18MB 0.50MB
datadog-dogstatsd-amd64-deb -0.00MB 59.10MB 59.10MB 0.50MB
datadog-dogstatsd-arm64-deb -0.00MB 56.57MB 56.57MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 31, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=55253733 --os-family=ubuntu

Note: This applies to commit 970c555

@jedupau jedupau force-pushed the jed/enable-ha-all-integrations branch from 81bf9da to a14ad13 Compare January 31, 2025 14:18
@jedupau jedupau changed the title [NDMII-3310] wip [NDMII-3310] Provide API for any integration to become HA Integration Jan 31, 2025
@jedupau jedupau marked this pull request as ready for review February 3, 2025 12:28
@jedupau jedupau requested review from a team as code owners February 3, 2025 12:28
@jedupau jedupau requested a review from FlorianVeaux February 3, 2025 12:28
@jedupau jedupau added the qa/done QA done before merge and regressions are covered by tests label Feb 3, 2025
@jedupau jedupau requested a review from a team as a code owner February 3, 2025 12:33
@jedupau jedupau removed the request for review from FlorianVeaux February 3, 2025 12:33
@jedupau jedupau force-pushed the jed/enable-ha-all-integrations branch from 661b3d2 to 9d57235 Compare February 3, 2025 16:26
Copy link
Member

@AlexandreYang AlexandreYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to test the the feature works fine for python integration too.

Also, having a e2e test would be great (can be a separate PR).

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just flagging a typo and making some other small adjustments to the release note

@jedupau jedupau marked this pull request as ready for review February 6, 2025 09:44
@jedupau jedupau marked this pull request as draft February 7, 2025 12:01
@jedupau jedupau marked this pull request as ready for review February 7, 2025 14:12
@jedupau jedupau force-pushed the jed/enable-ha-all-integrations branch from 3570867 to 53b00cb Compare February 7, 2025 14:18
@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 845.06MiB 858.45MiB 203.56MiB 214.3MiB
static_quality_gate_docker_agent_amd64 929.36MiB 942.69MiB 310.75MiB 321.56MiB

@jedupau jedupau closed this Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-metrics team/ndm-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants