chore(apm): use tagger ProcessID resolution

[wdhif]

What does this PR do?

Migrate the ProcessID resolution for APM to the tagger module.

Motivation

This is done to ensure consistency in Origin Detection behavior across Datadog Products.

Describe how you validated your changes

QA is done by unit and E2E tests but I also checked manually

• With a modified library (process_id_only) that does not send any container information:

Possible Drawbacks / Trade-offs

None.

Additional Notes

N/A

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 1e6393f8-569f-4f01-ac96-451fce5a5865

Baseline: 7a8951c
Comparison: a2a7c22
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.11	[-1.00, +5.22]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.89	[+0.81, +0.97]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.60	[-0.29, +1.48]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.26	[-0.20, +0.72]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.04	[-0.82, +0.91]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	+0.02	[-0.82, +0.86]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.28, +0.31]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.87, +0.87]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.00	[-0.06, +0.06]	1	Logs bounds checks dashboard
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.02, +0.02]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.01	[-0.65, +0.64]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.02	[-0.80, +0.77]	1	Logs
➖	file_tree	memory utilization	-0.03	[-0.10, +0.04]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.03	[-0.66, +0.60]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.06	[-0.83, +0.71]	1	Logs
➖	quality_gate_idle	memory utilization	-0.23	[-0.26, -0.19]	1	Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	intake_connections	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	intake_connections	10/10
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[agent-platform-auto-pr]

Uncompressed package size comparison

Comparison with ancestor 7a8951c3e3d96f7e948c20c72a97561b96970e44

Diff per package

package	diff	status	size	ancestor	threshold
datadog-dogstatsd-amd64-deb	0.00MB	✅	41.36MB	41.36MB	0.50MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	41.44MB	41.44MB	0.50MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	41.44MB	41.44MB	0.50MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	39.62MB	39.62MB	0.50MB
datadog-iot-agent-amd64-deb	0.00MB	✅	61.80MB	61.80MB	0.50MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	61.87MB	61.87MB	0.50MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	61.87MB	61.87MB	0.50MB
datadog-iot-agent-arm64-deb	0.00MB	✅	59.05MB	59.05MB	0.50MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	59.12MB	59.12MB	0.50MB
datadog-agent-aarch64-rpm	-0.00MB	✅	864.85MB	864.86MB	0.50MB
datadog-agent-arm64-deb	-0.00MB	✅	855.10MB	855.11MB	0.50MB
datadog-agent-x86_64-rpm	-0.01MB	✅	876.40MB	876.41MB	0.50MB
datadog-agent-x86_64-suse	-0.01MB	✅	876.40MB	876.41MB	0.50MB
datadog-agent-amd64-deb	-0.01MB	✅	866.63MB	866.64MB	0.50MB
datadog-heroku-agent-amd64-deb	-0.01MB	✅	443.29MB	443.30MB	0.50MB

Decision

✅ Passed

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=56149982 --os-family=ubuntu

Note: This applies to commit a2a7c22

[agent-platform-auto-pr]

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result	Quality gate	On disk size	On disk size limit	On wire size	On wire size limit
✅	static_quality_gate_agent_deb_amd64	838.39MiB	847.49MiB	202.3MiB	212.83MiB
✅	static_quality_gate_agent_deb_arm64	827.24MiB	836.66MiB	182.31MiB	192.17MiB
✅	static_quality_gate_agent_rpm_amd64	838.39MiB	858.45MiB	205.78MiB	214.3MiB
✅	static_quality_gate_agent_rpm_arm64	827.33MiB	836.66MiB	184.27MiB	194.46MiB
✅	static_quality_gate_agent_suse_amd64	838.28MiB	858.45MiB	205.78MiB	214.3MiB
✅	static_quality_gate_agent_suse_arm64	827.36MiB	836.66MiB	184.27MiB	194.46MiB
✅	static_quality_gate_dogstatsd_deb_amd64	39.52MiB	49.7MiB	10.54MiB	20.6MiB
✅	static_quality_gate_dogstatsd_deb_arm64	37.86MiB	48.1MiB	9.12MiB	19.1MiB
✅	static_quality_gate_dogstatsd_rpm_amd64	39.52MiB	49.7MiB	10.55MiB	20.6MiB
✅	static_quality_gate_dogstatsd_suse_amd64	39.52MiB	49.7MiB	10.55MiB	20.6MiB
✅	static_quality_gate_iot_agent_deb_amd64	59.01MiB	69.0MiB	14.83MiB	24.8MiB
✅	static_quality_gate_iot_agent_deb_arm64	56.39MiB	66.4MiB	12.78MiB	22.8MiB
✅	static_quality_gate_iot_agent_rpm_amd64	59.01MiB	69.0MiB	14.85MiB	24.8MiB
✅	static_quality_gate_iot_agent_rpm_arm64	56.39MiB	66.4MiB	12.82MiB	22.8MiB
✅	static_quality_gate_iot_agent_suse_amd64	59.01MiB	69.0MiB	14.85MiB	24.8MiB
✅	static_quality_gate_docker_agent_amd64	922.65MiB	931.7MiB	308.51MiB	318.67MiB
✅	static_quality_gate_docker_agent_arm64	934.97MiB	944.08MiB	292.53MiB	303.0MiB
✅	static_quality_gate_docker_agent_jmx_amd64	1.09GiB	1.1GiB	383.64MiB	393.75MiB
✅	static_quality_gate_docker_agent_jmx_arm64	1.1GiB	1.1GiB	363.63MiB	373.71MiB
✅	static_quality_gate_docker_dogstatsd_amd64	47.67MiB	57.88MiB	18.25MiB	28.29MiB
✅	static_quality_gate_docker_dogstatsd_arm64	46.05MiB	56.27MiB	17.01MiB	27.06MiB
✅	static_quality_gate_docker_cluster_agent_amd64	264.78MiB	277.7MiB	106.28MiB	117.28MiB
✅	static_quality_gate_docker_cluster_agent_arm64	280.81MiB	293.73MiB	101.12MiB	112.12MiB

[ichinaski]

maybe replace this test with the new logic? What other coverage exists for the change?

[wdhif]

Hey @ichinaski 👋

The tests regarding Origin Detection have been moved to the tagger: https://github.com/DataDog/datadog-agent/blob/main/comp/core/tagger/impl/local_tagger_test.go#L166-L176

What could also be done in the future is to split the GetContainerID() methods into ParseOriginInfo() and GetContainerID() that way we could have unit tests regarding the context and HTTP header parsing done by the Trace Agent.

[wdhif]

/merge

[dd-devflow]

View all feedbacks in Devflow UI.
2025-02-24 12:46:03 UTC ℹ️ Start processing command /merge

---

2025-02-24 12:46:07 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 30m.

---

2025-02-24 13:11:21 UTC ℹ️ MergeQueue: This merge request was merged