Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate constant #34296

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

hush-hush
Copy link
Member

What does this PR do?

We already have a const for that route.

Describe how you validated your changes

Running the CI is enough.

@hush-hush hush-hush requested a review from a team as a code owner February 21, 2025 11:10
@hush-hush hush-hush added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests team/agent-configuration labels Feb 21, 2025
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Feb 21, 2025
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=56543542 --os-family=ubuntu

Note: This applies to commit 4a03778

@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor b2b2a5a307c3a20711af4c6be37bef472aa8ddb8

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 868.63MB 868.63MB 0.50MB
datadog-agent-arm64-deb 0.00MB 857.97MB 857.97MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 41.39MB 41.39MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 41.47MB 41.47MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 41.47MB 41.47MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 39.65MB 39.65MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 445.88MB 445.88MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 61.84MB 61.84MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 61.91MB 61.91MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 61.91MB 61.91MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.09MB 59.09MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.16MB 59.16MB 0.50MB
datadog-agent-aarch64-rpm -0.00MB 867.72MB 867.72MB 0.50MB
datadog-agent-x86_64-rpm -0.00MB 878.40MB 878.40MB 0.50MB
datadog-agent-x86_64-suse -0.00MB 878.40MB 878.40MB 0.50MB

Decision

✅ Passed

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 840.19MiB 847.49MiB 203.0MiB 212.33MiB
static_quality_gate_agent_deb_arm64 829.97MiB 836.66MiB 181.01MiB 192.5MiB
static_quality_gate_agent_rpm_amd64 840.23MiB 847.82MiB 206.19MiB 215.76MiB
static_quality_gate_agent_rpm_arm64 830.04MiB 836.66MiB 185.28MiB 194.24MiB
static_quality_gate_agent_suse_amd64 840.28MiB 847.82MiB 206.19MiB 215.76MiB
static_quality_gate_agent_suse_arm64 829.95MiB 836.66MiB 185.28MiB 194.24MiB
static_quality_gate_dogstatsd_deb_amd64 39.55MiB 49.7MiB 10.55MiB 20.6MiB
static_quality_gate_dogstatsd_deb_arm64 37.89MiB 48.1MiB 9.12MiB 19.1MiB
static_quality_gate_dogstatsd_rpm_amd64 39.55MiB 49.7MiB 10.56MiB 20.6MiB
static_quality_gate_dogstatsd_suse_amd64 39.55MiB 49.7MiB 10.56MiB 20.6MiB
static_quality_gate_iot_agent_deb_amd64 59.05MiB 69.0MiB 14.84MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.43MiB 66.4MiB 12.81MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.05MiB 69.0MiB 14.86MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.43MiB 66.4MiB 12.82MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.05MiB 69.0MiB 14.86MiB 24.8MiB
static_quality_gate_docker_agent_amd64 924.56MiB 931.7MiB 308.97MiB 318.67MiB
static_quality_gate_docker_agent_arm64 937.66MiB 944.08MiB 293.97MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.1GiB 1.1GiB 384.06MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.1GiB 1.1GiB 365.03MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.69MiB 57.88MiB 18.26MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.08MiB 56.27MiB 17.02MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 264.85MiB 274.78MiB 106.32MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.82MiB 290.82MiB 101.15MiB 111.12MiB

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: eb2466fa-c6fd-4498-8e22-6f2590bbcda9

Baseline: b2b2a5a
Comparison: 4a03778
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +0.33 [+0.28, +0.39] 1 Logs
quality_gate_idle_all_features memory utilization +0.13 [+0.08, +0.18] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.09 [+0.03, +0.14] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.07 [-0.72, +0.86] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.07 [-0.71, +0.84] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.03 [-0.61, +0.66] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.62, +0.66] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.29, +0.32] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.00 [-0.82, +0.82] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.00 [-0.84, +0.84] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.03, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.84, +0.81] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.25 [-0.71, +0.22] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.37 [-0.42, -0.31] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.72 [-2.64, -0.81] 1 Logs
quality_gate_logs % cpu utilization -2.32 [-5.22, +0.59] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@hush-hush
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 24, 2025

View all feedbacks in Devflow UI.
2025-02-24 14:40:06 UTC ℹ️ Start processing command /merge


2025-02-24 14:40:10 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 29m.


2025-02-24 15:08:33 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 59d4791 into main Feb 24, 2025
265 checks passed
@dd-mergequeue dd-mergequeue bot deleted the maxime/remove-duplicate-constant branch February 24, 2025 15:08
@github-actions github-actions bot added this to the 7.65.0 milestone Feb 24, 2025
jedupau pushed a commit that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done QA done before merge and regressions are covered by tests short review PR is simple enough to be reviewed quickly team/agent-configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants