Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump integrations core to HEAD #34342

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot requested review from a team as code owners February 24, 2025 04:02
@github-actions github-actions bot added this to the 7.65.0 milestone Feb 24, 2025
@github-actions github-actions bot added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Feb 24, 2025
@agent-platform-auto-pr
Copy link
Contributor

Uncompressed package size comparison

Comparison with ancestor 7b722a315a84db8b0ccdbc1d8300df192c61fddb

Diff per package
package diff status size ancestor threshold
datadog-agent-x86_64-rpm 0.02MB ⚠️ 879.06MB 879.04MB 0.50MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 879.06MB 879.04MB 0.50MB
datadog-agent-aarch64-rpm 0.02MB ⚠️ 868.36MB 868.34MB 0.50MB
datadog-agent-amd64-deb 0.02MB ⚠️ 869.29MB 869.27MB 0.50MB
datadog-heroku-agent-amd64-deb 0.02MB ⚠️ 446.36MB 446.34MB 0.50MB
datadog-agent-arm64-deb 0.02MB ⚠️ 858.61MB 858.59MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 41.40MB 41.40MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 41.48MB 41.48MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 41.48MB 41.48MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 39.66MB 39.66MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.02MB 62.02MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.26MB 59.26MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.33MB 59.33MB 0.50MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 840.38MiB 847.49MiB 203.05MiB 212.33MiB
static_quality_gate_agent_deb_arm64 830.17MiB 836.66MiB 184.67MiB 192.5MiB
static_quality_gate_agent_rpm_amd64 840.37MiB 847.82MiB 206.0MiB 215.76MiB
static_quality_gate_agent_rpm_arm64 830.16MiB 836.66MiB 185.42MiB 194.24MiB
static_quality_gate_agent_suse_amd64 840.37MiB 847.82MiB 206.0MiB 215.76MiB
static_quality_gate_agent_suse_arm64 830.16MiB 836.66MiB 185.42MiB 194.24MiB
static_quality_gate_dogstatsd_deb_amd64 39.56MiB 49.7MiB 10.55MiB 20.6MiB
static_quality_gate_dogstatsd_deb_arm64 37.9MiB 48.1MiB 9.13MiB 19.1MiB
static_quality_gate_dogstatsd_rpm_amd64 39.56MiB 49.7MiB 10.56MiB 20.6MiB
static_quality_gate_dogstatsd_suse_amd64 39.56MiB 49.7MiB 10.56MiB 20.6MiB
static_quality_gate_iot_agent_deb_amd64 59.22MiB 69.0MiB 14.88MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.59MiB 66.4MiB 12.83MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.22MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.59MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.22MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 925.15MiB 931.7MiB 309.16MiB 318.67MiB
static_quality_gate_docker_agent_arm64 938.22MiB 944.08MiB 294.15MiB 303.0MiB
static_quality_gate_docker_agent_jmx_amd64 1.1GiB 1.1GiB 384.27MiB 393.75MiB
static_quality_gate_docker_agent_jmx_arm64 1.1GiB 1.1GiB 365.23MiB 373.71MiB
static_quality_gate_docker_dogstatsd_amd64 47.7MiB 57.88MiB 18.26MiB 28.29MiB
static_quality_gate_docker_dogstatsd_arm64 46.09MiB 56.27MiB 17.02MiB 27.06MiB
static_quality_gate_docker_cluster_agent_amd64 264.95MiB 274.78MiB 106.33MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.91MiB 290.82MiB 101.19MiB 111.12MiB

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 56700903 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b5420ed2-fe88-4786-90ee-98402893b472

Baseline: 7b722a3
Comparison: 57a185e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +0.31 [+0.25, +0.37] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.20 [+0.16, +0.24] 1 Logs bounds checks dashboard
file_to_blackhole_0ms_latency_http1 egress throughput +0.06 [-0.73, +0.84] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.73, +0.84] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.04 [-0.62, +0.70] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.03 [-0.80, +0.86] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput +0.03 [-0.78, +0.85] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.76, +0.78] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.02] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.29, +0.26] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.16 [-0.22, -0.10] 1 Logs
file_tree memory utilization -0.21 [-0.26, -0.16] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.30 [-1.21, +0.61] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.48 [-0.94, -0.01] 1 Logs
quality_gate_logs % cpu utilization -1.25 [-4.28, +1.78] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@iliakur
Copy link
Contributor

iliakur commented Feb 24, 2025

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 24, 2025

View all feedbacks in Devflow UI.
2025-02-24 09:28:33 UTC ℹ️ Start processing command /merge


2025-02-24 09:28:38 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-24 09:31:08 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 30m.


2025-02-24 09:59:19 UTC ℹ️ MergeQueue: This merge request was merged

@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/integrations and removed changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Feb 24, 2025
@dd-mergequeue dd-mergequeue bot merged commit 7ce089c into main Feb 24, 2025
285 checks passed
@dd-mergequeue dd-mergequeue bot deleted the bump-integrations-core-1740369732 branch February 24, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants