Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "autoinstrumentation: pin minor library versions" #34442

Merged

Conversation

stanistan
Copy link
Member

Reverts #34182

@stanistan stanistan requested review from a team as code owners February 25, 2025 18:05
@github-actions github-actions bot added team/container-platform The Container Platform Team team/injection-platform medium review PR review might take time labels Feb 25, 2025
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 25, 2025

[Fast Unit Tests Report]

On pipeline 56955734 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Feb 25, 2025

Uncompressed package size comparison

Comparison with ancestor f6ce0a8999212f678d7a9b0b3a8f38557d437f05

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.00MB 817.87MB 817.87MB 0.50MB
datadog-agent-x86_64-rpm 0.00MB 827.66MB 827.66MB 0.50MB
datadog-agent-x86_64-suse 0.00MB 827.66MB 827.66MB 0.50MB
datadog-agent-arm64-deb 0.00MB 808.84MB 808.84MB 0.50MB
datadog-agent-aarch64-rpm 0.00MB 818.62MB 818.62MB 0.50MB
datadog-dogstatsd-amd64-deb 0.00MB 39.42MB 39.42MB 0.50MB
datadog-dogstatsd-x86_64-rpm 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-x86_64-suse 0.00MB 39.50MB 39.50MB 0.50MB
datadog-dogstatsd-arm64-deb 0.00MB 37.96MB 37.96MB 0.50MB
datadog-heroku-agent-amd64-deb 0.00MB 443.28MB 443.28MB 0.50MB
datadog-iot-agent-amd64-deb 0.00MB 62.02MB 62.02MB 0.50MB
datadog-iot-agent-x86_64-rpm 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-x86_64-suse 0.00MB 62.09MB 62.09MB 0.50MB
datadog-iot-agent-arm64-deb 0.00MB 59.27MB 59.27MB 0.50MB
datadog-iot-agent-aarch64-rpm 0.00MB 59.33MB 59.33MB 0.50MB

Decision

✅ Passed

Copy link

cit-pr-commenter bot commented Feb 25, 2025

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: a8f49d26-c9f3-45bc-bcac-e6eb2ddf5a5c

Baseline: f6ce0a8
Comparison: 229b682
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.78 [+0.85, +2.72] 1 Logs
quality_gate_logs % cpu utilization +0.75 [-2.16, +3.66] 1 Logs
file_tree memory utilization +0.17 [+0.12, +0.22] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.12 [-0.35, +0.58] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.05 [-0.74, +0.84] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.03 [-0.28, +0.33] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.81, +0.85] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.78, +0.83] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.63, +0.64] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.02, +0.03] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.69, +0.65] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.02 [-0.81, +0.76] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.20 [-0.98, +0.57] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.22 [-0.29, -0.14] 1 Logs
quality_gate_idle_all_features memory utilization -0.27 [-0.31, -0.22] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization -0.68 [-0.73, -0.63] 1 Logs bounds checks dashboard

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle intake_connections 10/10 bounds checks dashboard
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs intake_connections 10/10
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@stanistan stanistan added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Feb 25, 2025
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=56955734 --os-family=ubuntu

Note: This applies to commit 229b682

@agent-platform-auto-pr
Copy link
Contributor

Static quality checks ✅

Please find below the results from static quality gates

Successful checks

Info

Result Quality gate On disk size On disk size limit On wire size On wire size limit
static_quality_gate_agent_deb_amd64 791.8MiB 817.79MiB 192.6MiB 204.92MiB
static_quality_gate_agent_deb_arm64 783.23MiB 808.76MiB 174.58MiB 186.5MiB
static_quality_gate_agent_rpm_amd64 791.79MiB 817.82MiB 195.03MiB 208.12MiB
static_quality_gate_agent_rpm_arm64 783.18MiB 808.76MiB 176.42MiB 188.34MiB
static_quality_gate_agent_suse_amd64 791.86MiB 817.82MiB 195.03MiB 208.12MiB
static_quality_gate_agent_suse_arm64 783.2MiB 808.86MiB 176.42MiB 188.33MiB
static_quality_gate_dogstatsd_deb_amd64 37.67MiB 47.7MiB 9.78MiB 19.8MiB
static_quality_gate_dogstatsd_deb_arm64 36.27MiB 46.3MiB 8.48MiB 18.5MiB
static_quality_gate_dogstatsd_rpm_amd64 37.67MiB 47.7MiB 9.79MiB 19.8MiB
static_quality_gate_dogstatsd_suse_amd64 37.67MiB 47.7MiB 9.79MiB 19.8MiB
static_quality_gate_iot_agent_deb_amd64 59.23MiB 69.0MiB 14.89MiB 24.8MiB
static_quality_gate_iot_agent_deb_arm64 56.59MiB 66.4MiB 12.86MiB 22.8MiB
static_quality_gate_iot_agent_rpm_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_iot_agent_rpm_arm64 56.6MiB 66.4MiB 12.85MiB 22.8MiB
static_quality_gate_iot_agent_suse_amd64 59.23MiB 69.0MiB 14.9MiB 24.8MiB
static_quality_gate_docker_agent_amd64 876.12MiB 902.2MiB 294.2MiB 308.43MiB
static_quality_gate_docker_agent_arm64 890.78MiB 916.47MiB 280.46MiB 294.23MiB
static_quality_gate_docker_agent_jmx_amd64 1.05GiB 1.07GiB 369.32MiB 383.54MiB
static_quality_gate_docker_agent_jmx_arm64 1.05GiB 1.08GiB 351.56MiB 365.31MiB
static_quality_gate_docker_dogstatsd_amd64 45.81MiB 55.78MiB 17.28MiB 27.29MiB
static_quality_gate_docker_dogstatsd_arm64 44.45MiB 54.47MiB 16.16MiB 26.16MiB
static_quality_gate_docker_cluster_agent_amd64 264.94MiB 274.78MiB 106.34MiB 116.28MiB
static_quality_gate_docker_cluster_agent_arm64 280.91MiB 290.82MiB 101.17MiB 111.12MiB

@@ -606,7 +584,10 @@ func TestExtractLibInfo(t *testing.T) {
},
containerRegistry: "registry",
expectedLibsToInject: []libInfo{
java.libInfo("", defaultLibImageVersions[java]),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes were nice, but we can re-add them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@stanistan
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Feb 25, 2025

View all feedbacks in Devflow UI.
2025-02-25 22:30:33 UTC ℹ️ Start processing command /merge


2025-02-25 22:30:37 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 28m.


2025-02-25 22:57:40 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 865dc6c into main Feb 25, 2025
257 of 267 checks passed
@dd-mergequeue dd-mergequeue bot deleted the revert-34182-stanistan/INPLAT-439/pin-minor-versions branch February 25, 2025 22:57
@github-actions github-actions bot added this to the 7.65.0 milestone Feb 25, 2025
@stanistan stanistan added the backport/7.64.x Automatically create a backport PR to 7.64.x label Feb 26, 2025
agent-platform-auto-pr bot pushed a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.64.x Automatically create a backport PR to 7.64.x changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/container-platform The Container Platform Team team/injection-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants