-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for scanning jar from loaded class #8370
base: master
Are you sure you want to change the base?
Conversation
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 8 metrics, 7 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (327.594 µs) : 272, 384
. : milestone, 328,
basic (311.558 µs) : 297, 326
. : milestone, 312,
loop (10.146 ms) : 10094, 10199
. : milestone, 10146,
section candidate
noprobe (326.748 µs) : 257, 396
. : milestone, 327,
basic (313.799 µs) : 299, 328
. : milestone, 314,
loop (10.152 ms) : 10096, 10207
. : milestone, 10152,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 56 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~144ab64a97, baseline=1.47.0-SNAPSHOT~a3d58f1cfd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045816
Total [baseline] (8.664 s) : 0, 8663910
Agent [candidate] (1.052 s) : 0, 1052321
Total [candidate] (8.636 s) : 0, 8636422
section iast
Agent [baseline] (1.181 s) : 0, 1180854
Total [baseline] (9.306 s) : 0, 9306370
Agent [candidate] (1.176 s) : 0, 1175958
Total [candidate] (9.37 s) : 0, 9369547
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170855
Total [baseline] (9.23 s) : 0, 9229806
Agent [candidate] (1.175 s) : 0, 1175021
Total [candidate] (9.215 s) : 0, 9214620
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170449
Total [baseline] (9.239 s) : 0, 9238925
Agent [candidate] (1.17 s) : 0, 1169720
Total [candidate] (9.246 s) : 0, 9245684
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~144ab64a97, baseline=1.47.0-SNAPSHOT~a3d58f1cfd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.646 ms) : 0, 719646
BytebuddyAgent [candidate] (722.587 ms) : 0, 722587
GlobalTracer [baseline] (241.639 ms) : 0, 241639
GlobalTracer [candidate] (244.556 ms) : 0, 244556
AppSec [baseline] (55.51 ms) : 0, 55510
AppSec [candidate] (55.292 ms) : 0, 55292
Remote Config [baseline] (718.646 µs) : 0, 719
Remote Config [candidate] (719.159 µs) : 0, 719
Telemetry [baseline] (13.049 ms) : 0, 13049
Telemetry [candidate] (13.825 ms) : 0, 13825
section iast
BytebuddyAgent [baseline] (842.963 ms) : 0, 842963
BytebuddyAgent [candidate] (836.79 ms) : 0, 836790
GlobalTracer [baseline] (232.6 ms) : 0, 232600
GlobalTracer [candidate] (234.14 ms) : 0, 234140
IAST [baseline] (22.978 ms) : 0, 22978
IAST [candidate] (22.977 ms) : 0, 22977
AppSec [baseline] (57.506 ms) : 0, 57506
AppSec [candidate] (57.318 ms) : 0, 57318
Remote Config [baseline] (619.106 µs) : 0, 619
Remote Config [candidate] (635.823 µs) : 0, 636
Telemetry [baseline] (8.878 ms) : 0, 8878
Telemetry [candidate] (8.83 ms) : 0, 8830
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.81 ms) : 0, 834810
BytebuddyAgent [candidate] (836.087 ms) : 0, 836087
GlobalTracer [baseline] (231.093 ms) : 0, 231093
GlobalTracer [candidate] (234.117 ms) : 0, 234117
IAST [baseline] (22.775 ms) : 0, 22775
IAST [candidate] (23.037 ms) : 0, 23037
AppSec [baseline] (57.503 ms) : 0, 57503
AppSec [candidate] (57.163 ms) : 0, 57163
Remote Config [baseline] (631.059 µs) : 0, 631
Remote Config [candidate] (628.51 µs) : 0, 629
Telemetry [baseline] (8.765 ms) : 0, 8765
Telemetry [candidate] (8.734 ms) : 0, 8734
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (834.548 ms) : 0, 834548
BytebuddyAgent [candidate] (832.378 ms) : 0, 832378
GlobalTracer [baseline] (232.178 ms) : 0, 232178
GlobalTracer [candidate] (233.881 ms) : 0, 233881
IAST [baseline] (26.098 ms) : 0, 26098
IAST [candidate] (26.715 ms) : 0, 26715
AppSec [baseline] (53.174 ms) : 0, 53174
AppSec [candidate] (52.211 ms) : 0, 52211
Remote Config [baseline] (605.294 µs) : 0, 605
Remote Config [candidate] (622.502 µs) : 0, 623
Telemetry [baseline] (8.596 ms) : 0, 8596
Telemetry [candidate] (8.64 ms) : 0, 8640
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~144ab64a97, baseline=1.47.0-SNAPSHOT~a3d58f1cfd
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.041 s) : 0, 1041087
Total [baseline] (10.482 s) : 0, 10481784
Agent [candidate] (1.052 s) : 0, 1052128
Total [candidate] (10.501 s) : 0, 10500620
section appsec
Agent [baseline] (1.189 s) : 0, 1189245
Total [baseline] (10.849 s) : 0, 10849087
Agent [candidate] (1.191 s) : 0, 1191023
Total [candidate] (10.788 s) : 0, 10787830
section iast
Agent [baseline] (1.173 s) : 0, 1172671
Total [baseline] (11.085 s) : 0, 11084887
Agent [candidate] (1.176 s) : 0, 1176338
Total [candidate] (11.085 s) : 0, 11085453
section profiling
Agent [baseline] (1.276 s) : 0, 1276282
Total [baseline] (10.879 s) : 0, 10879476
Agent [candidate] (1.28 s) : 0, 1279993
Total [candidate] (10.949 s) : 0, 10948944
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~144ab64a97, baseline=1.47.0-SNAPSHOT~a3d58f1cfd
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.2 ms) : 0, 717200
BytebuddyAgent [candidate] (723.296 ms) : 0, 723296
GlobalTracer [baseline] (241.18 ms) : 0, 241180
GlobalTracer [candidate] (245.338 ms) : 0, 245338
AppSec [baseline] (55.872 ms) : 0, 55872
AppSec [candidate] (55.749 ms) : 0, 55749
Remote Config [baseline] (735.129 µs) : 0, 735
Remote Config [candidate] (723.545 µs) : 0, 724
Telemetry [baseline] (10.858 ms) : 0, 10858
Telemetry [candidate] (11.612 ms) : 0, 11612
section appsec
BytebuddyAgent [baseline] (738.912 ms) : 0, 738912
BytebuddyAgent [candidate] (737.824 ms) : 0, 737824
GlobalTracer [baseline] (238.576 ms) : 0, 238576
GlobalTracer [candidate] (241.391 ms) : 0, 241391
AppSec [baseline] (176.451 ms) : 0, 176451
AppSec [candidate] (176.293 ms) : 0, 176293
Remote Config [baseline] (653.188 µs) : 0, 653
Remote Config [candidate] (662.337 µs) : 0, 662
Telemetry [baseline] (8.291 ms) : 0, 8291
Telemetry [candidate] (8.699 ms) : 0, 8699
IAST [baseline] (22.014 ms) : 0, 22014
IAST [candidate] (21.679 ms) : 0, 21679
section iast
BytebuddyAgent [baseline] (836.414 ms) : 0, 836414
BytebuddyAgent [candidate] (837.284 ms) : 0, 837284
GlobalTracer [baseline] (231.634 ms) : 0, 231634
GlobalTracer [candidate] (234.266 ms) : 0, 234266
AppSec [baseline] (57.235 ms) : 0, 57235
AppSec [candidate] (57.252 ms) : 0, 57252
Remote Config [baseline] (612.363 µs) : 0, 612
Remote Config [candidate] (623.963 µs) : 0, 624
Telemetry [baseline] (8.824 ms) : 0, 8824
Telemetry [candidate] (8.737 ms) : 0, 8737
IAST [baseline] (22.762 ms) : 0, 22762
IAST [candidate] (22.849 ms) : 0, 22849
section profiling
ProfilingAgent [baseline] (97.253 ms) : 0, 97253
ProfilingAgent [candidate] (96.495 ms) : 0, 96495
BytebuddyAgent [baseline] (714.529 ms) : 0, 714529
BytebuddyAgent [candidate] (718.025 ms) : 0, 718025
GlobalTracer [baseline] (355.682 ms) : 0, 355682
GlobalTracer [candidate] (357.96 ms) : 0, 357960
AppSec [baseline] (56.209 ms) : 0, 56209
AppSec [candidate] (54.934 ms) : 0, 54934
Remote Config [baseline] (716.648 µs) : 0, 717
Remote Config [candidate] (717.781 µs) : 0, 718
Telemetry [baseline] (9.041 ms) : 0, 9041
Telemetry [candidate] (9.009 ms) : 0, 9009
Profiling [baseline] (97.277 ms) : 0, 97277
Profiling [candidate] (96.519 ms) : 0, 96519
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 18 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~144ab64a97, baseline=1.47.0-SNAPSHOT~a3d58f1cfd
dateFormat X
axisFormat %s
section baseline
no_agent (1.358 ms) : 1338, 1378
. : milestone, 1358,
appsec (1.754 ms) : 1732, 1777
. : milestone, 1754,
appsec_no_iast (1.733 ms) : 1710, 1756
. : milestone, 1733,
iast (1.501 ms) : 1476, 1526
. : milestone, 1501,
profiling (1.537 ms) : 1512, 1562
. : milestone, 1537,
tracing (1.506 ms) : 1482, 1530
. : milestone, 1506,
section candidate
no_agent (1.351 ms) : 1331, 1372
. : milestone, 1351,
appsec (1.758 ms) : 1734, 1781
. : milestone, 1758,
appsec_no_iast (1.73 ms) : 1705, 1755
. : milestone, 1730,
iast (1.498 ms) : 1473, 1524
. : milestone, 1498,
profiling (1.5 ms) : 1477, 1524
. : milestone, 1500,
tracing (1.486 ms) : 1461, 1511
. : milestone, 1486,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~144ab64a97, baseline=1.47.0-SNAPSHOT~a3d58f1cfd
dateFormat X
axisFormat %s
section baseline
no_agent (376.48 µs) : 357, 396
. : milestone, 376,
iast (501.073 µs) : 479, 523
. : milestone, 501,
iast_FULL (739.701 µs) : 718, 762
. : milestone, 740,
iast_GLOBAL (557.029 µs) : 534, 580
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (503.582 µs) : 482, 525
. : milestone, 504,
iast_INACTIVE (462.809 µs) : 440, 485
. : milestone, 463,
iast_TELEMETRY_OFF (496.088 µs) : 473, 520
. : milestone, 496,
tracing (452.589 µs) : 432, 474
. : milestone, 453,
section candidate
no_agent (376.685 µs) : 357, 396
. : milestone, 377,
iast (499.631 µs) : 478, 521
. : milestone, 500,
iast_FULL (742.875 µs) : 721, 765
. : milestone, 743,
iast_GLOBAL (549.218 µs) : 527, 571
. : milestone, 549,
iast_HARDCODED_SECRET_DISABLED (498.23 µs) : 477, 520
. : milestone, 498,
iast_INACTIVE (456.071 µs) : 434, 478
. : milestone, 456,
iast_TELEMETRY_OFF (494.148 µs) : 470, 518
. : milestone, 494,
tracing (448.787 µs) : 427, 470
. : milestone, 449,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~144ab64a97, baseline=1.47.0-SNAPSHOT~a3d58f1cfd
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.371 ms) : 2328, 2415
. : milestone, 2371,
iast (2.119 ms) : 2065, 2174
. : milestone, 2119,
iast_GLOBAL (2.157 ms) : 2102, 2212
. : milestone, 2157,
profiling (2.436 ms) : 2191, 2680
. : milestone, 2436,
tracing (1.954 ms) : 1911, 1996
. : milestone, 1954,
section candidate
no_agent (1.478 ms) : 1467, 1490
. : milestone, 1478,
appsec (2.372 ms) : 2329, 2415
. : milestone, 2372,
iast (2.129 ms) : 2074, 2184
. : milestone, 2129,
iast_GLOBAL (2.16 ms) : 2105, 2216
. : milestone, 2160,
profiling (1.975 ms) : 1932, 2019
. : milestone, 1975,
tracing (1.95 ms) : 1908, 1992
. : milestone, 1950,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~144ab64a97, baseline=1.47.0-SNAPSHOT~a3d58f1cfd
dateFormat X
axisFormat %s
section baseline
no_agent (15.119 s) : 15119000, 15119000
. : milestone, 15119000,
appsec (15.057 s) : 15057000, 15057000
. : milestone, 15057000,
iast (18.996 s) : 18996000, 18996000
. : milestone, 18996000,
iast_GLOBAL (17.996 s) : 17996000, 17996000
. : milestone, 17996000,
profiling (15.689 s) : 15689000, 15689000
. : milestone, 15689000,
tracing (15.092 s) : 15092000, 15092000
. : milestone, 15092000,
section candidate
no_agent (15.205 s) : 15205000, 15205000
. : milestone, 15205000,
appsec (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
iast (18.725 s) : 18725000, 18725000
. : milestone, 18725000,
iast_GLOBAL (17.954 s) : 17954000, 17954000
. : milestone, 17954000,
profiling (15.633 s) : 15633000, 15633000
. : milestone, 15633000,
tracing (14.904 s) : 14904000, 14904000
. : milestone, 14904000,
|
b3ef438
to
b08db2d
Compare
when a class is loaded we are now locating the jar containing the class and push the jar to a queue to be scanned by a background thread like for the initial process of SymDB enablement Add more information into SymDB report of total class count processed total jars scanned and histogram of class count by scanned jar
b08db2d
to
144ab64
Compare
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]