-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade(tracer): Use libdatadog for Stable Config implementation #8436
Draft
BaptisteFoy
wants to merge
4
commits into
mtoff/stable_config
Choose a base branch
from
paullgdc/stable_config/common_component
base: mtoff/stable_config
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
upgrade(tracer): Use libdatadog for Stable Config implementation #8436
BaptisteFoy
wants to merge
4
commits into
mtoff/stable_config
from
paullgdc/stable_config/common_component
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
605afec
to
a938c8e
Compare
BenchmarksStartupParameters
See matching parameters
SummaryFound 7 performance improvements and 4 performance regressions! Performance is the same for 45 metrics, 7 unstable metrics.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~a938c8e65e, baseline=1.47.0-SNAPSHOT~19ce7f1a2a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.04 s) : 0, 1039693
Total [baseline] (10.432 s) : 0, 10431575
Agent [candidate] (1.047 s) : 0, 1046611
Total [candidate] (10.413 s) : 0, 10413002
section appsec
Agent [baseline] (1.181 s) : 0, 1180683
Total [baseline] (10.759 s) : 0, 10758892
Agent [candidate] (1.149 s) : 0, 1148639
Total [candidate] (10.723 s) : 0, 10723382
section iast
Agent [baseline] (1.174 s) : 0, 1174038
Total [baseline] (10.999 s) : 0, 10998734
Agent [candidate] (1.17 s) : 0, 1170309
Total [candidate] (10.954 s) : 0, 10954156
section profiling
Agent [baseline] (1.262 s) : 0, 1262351
Total [baseline] (10.85 s) : 0, 10849843
Agent [candidate] (1.242 s) : 0, 1242059
Total [candidate] (10.791 s) : 0, 10791088
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~a938c8e65e, baseline=1.47.0-SNAPSHOT~19ce7f1a2a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.723 ms) : 0, 716723
BytebuddyAgent [candidate] (722.659 ms) : 0, 722659
GlobalTracer [baseline] (239.411 ms) : 0, 239411
GlobalTracer [candidate] (237.403 ms) : 0, 237403
AppSec [baseline] (55.404 ms) : 0, 55404
AppSec [candidate] (61.822 ms) : 0, 61822
Remote Config [baseline] (695.022 µs) : 0, 695
Remote Config [candidate] (678.555 µs) : 0, 679
Telemetry [baseline] (12.303 ms) : 0, 12303
Telemetry [candidate] (9.154 ms) : 0, 9154
section appsec
BytebuddyAgent [baseline] (732.85 ms) : 0, 732850
BytebuddyAgent [candidate] (729.092 ms) : 0, 729092
GlobalTracer [baseline] (236.325 ms) : 0, 236325
GlobalTracer [candidate] (236.706 ms) : 0, 236706
AppSec [baseline] (176.789 ms) : 0, 176789
AppSec [candidate] (148.495 ms) : 0, 148495
Remote Config [baseline] (656.675 µs) : 0, 657
Remote Config [candidate] (649.939 µs) : 0, 650
Telemetry [baseline] (8.229 ms) : 0, 8229
Telemetry [candidate] (8.162 ms) : 0, 8162
IAST [baseline] (21.184 ms) : 0, 21184
IAST [candidate] (21.5 ms) : 0, 21500
section iast
BytebuddyAgent [baseline] (837.966 ms) : 0, 837966
BytebuddyAgent [candidate] (832.712 ms) : 0, 832712
GlobalTracer [baseline] (231.104 ms) : 0, 231104
GlobalTracer [candidate] (234.807 ms) : 0, 234807
AppSec [baseline] (57.377 ms) : 0, 57377
AppSec [candidate] (49.135 ms) : 0, 49135
Remote Config [baseline] (623.546 µs) : 0, 624
Remote Config [candidate] (623.92 µs) : 0, 624
Telemetry [baseline] (8.778 ms) : 0, 8778
Telemetry [candidate] (8.762 ms) : 0, 8762
IAST [baseline] (22.872 ms) : 0, 22872
IAST [candidate] (29.431 ms) : 0, 29431
section profiling
ProfilingAgent [baseline] (95.86 ms) : 0, 95860
ProfilingAgent [candidate] (100.733 ms) : 0, 100733
BytebuddyAgent [baseline] (708.804 ms) : 0, 708804
BytebuddyAgent [candidate] (710.765 ms) : 0, 710765
GlobalTracer [baseline] (350.407 ms) : 0, 350407
GlobalTracer [candidate] (328.292 ms) : 0, 328292
AppSec [baseline] (55.291 ms) : 0, 55291
AppSec [candidate] (53.432 ms) : 0, 53432
Remote Config [baseline] (672.56 µs) : 0, 673
Remote Config [candidate] (663.867 µs) : 0, 664
Telemetry [baseline] (8.942 ms) : 0, 8942
Telemetry [candidate] (8.901 ms) : 0, 8901
Profiling [baseline] (95.887 ms) : 0, 95887
Profiling [candidate] (100.761 ms) : 0, 100761
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~a938c8e65e, baseline=1.47.0-SNAPSHOT~19ce7f1a2a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048630
Total [baseline] (8.684 s) : 0, 8683549
Agent [candidate] (1.045 s) : 0, 1044562
Total [candidate] (8.617 s) : 0, 8617261
section iast
Agent [baseline] (1.182 s) : 0, 1182126
Total [baseline] (9.267 s) : 0, 9267149
Agent [candidate] (1.159 s) : 0, 1159324
Total [candidate] (9.196 s) : 0, 9195618
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.171 s) : 0, 1170951
Total [baseline] (9.235 s) : 0, 9235288
Agent [candidate] (1.162 s) : 0, 1161553
Total [candidate] (9.153 s) : 0, 9153293
section iast_TELEMETRY_OFF
Agent [baseline] (1.184 s) : 0, 1184075
Total [baseline] (9.248 s) : 0, 9248152
Agent [candidate] (1.16 s) : 0, 1160308
Total [candidate] (9.211 s) : 0, 9211459
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~a938c8e65e, baseline=1.47.0-SNAPSHOT~19ce7f1a2a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (722.926 ms) : 0, 722926
BytebuddyAgent [candidate] (721.172 ms) : 0, 721172
GlobalTracer [baseline] (239.99 ms) : 0, 239990
GlobalTracer [candidate] (237.112 ms) : 0, 237112
AppSec [baseline] (55.412 ms) : 0, 55412
AppSec [candidate] (61.112 ms) : 0, 61112
Remote Config [baseline] (689.333 µs) : 0, 689
Remote Config [candidate] (656.654 µs) : 0, 657
Telemetry [baseline] (14.255 ms) : 0, 14255
Telemetry [candidate] (9.593 ms) : 0, 9593
section iast
BytebuddyAgent [baseline] (845.076 ms) : 0, 845076
BytebuddyAgent [candidate] (824.673 ms) : 0, 824673
GlobalTracer [baseline] (231.731 ms) : 0, 231731
GlobalTracer [candidate] (232.927 ms) : 0, 232927
IAST [baseline] (23.232 ms) : 0, 23232
IAST [candidate] (29.145 ms) : 0, 29145
AppSec [baseline] (57.393 ms) : 0, 57393
AppSec [candidate] (48.43 ms) : 0, 48430
Remote Config [baseline] (606.661 µs) : 0, 607
Remote Config [candidate] (606.175 µs) : 0, 606
Telemetry [baseline] (8.697 ms) : 0, 8697
Telemetry [candidate] (8.766 ms) : 0, 8766
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (836.279 ms) : 0, 836279
BytebuddyAgent [candidate] (825.807 ms) : 0, 825807
GlobalTracer [baseline] (230.456 ms) : 0, 230456
GlobalTracer [candidate] (232.477 ms) : 0, 232477
IAST [baseline] (22.589 ms) : 0, 22589
IAST [candidate] (30.207 ms) : 0, 30207
AppSec [baseline] (57.247 ms) : 0, 57247
AppSec [candidate] (48.842 ms) : 0, 48842
Remote Config [baseline] (596.162 µs) : 0, 596
Remote Config [candidate] (619.215 µs) : 0, 619
Telemetry [baseline] (8.547 ms) : 0, 8547
Telemetry [candidate] (8.766 ms) : 0, 8766
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (845.816 ms) : 0, 845816
BytebuddyAgent [candidate] (825.015 ms) : 0, 825015
GlobalTracer [baseline] (233.017 ms) : 0, 233017
GlobalTracer [candidate] (231.652 ms) : 0, 231652
IAST [baseline] (24.894 ms) : 0, 24894
IAST [candidate] (30.687 ms) : 0, 30687
AppSec [baseline] (55.421 ms) : 0, 55421
AppSec [candidate] (48.843 ms) : 0, 48843
Remote Config [baseline] (626.593 µs) : 0, 627
Remote Config [candidate] (610.742 µs) : 0, 611
Telemetry [baseline] (8.769 ms) : 0, 8769
Telemetry [candidate] (8.643 ms) : 0, 8643
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 17 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~a938c8e65e, baseline=1.47.0-SNAPSHOT~19ce7f1a2a
dateFormat X
axisFormat %s
section baseline
no_agent (382.61 µs) : 363, 403
. : milestone, 383,
iast (505.558 µs) : 484, 527
. : milestone, 506,
iast_FULL (734.469 µs) : 713, 756
. : milestone, 734,
iast_GLOBAL (558.144 µs) : 536, 580
. : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (508.266 µs) : 485, 532
. : milestone, 508,
iast_INACTIVE (463.147 µs) : 441, 485
. : milestone, 463,
iast_TELEMETRY_OFF (497.619 µs) : 474, 521
. : milestone, 498,
tracing (454.154 µs) : 432, 476
. : milestone, 454,
section candidate
no_agent (376.802 µs) : 357, 397
. : milestone, 377,
iast (509.105 µs) : 487, 531
. : milestone, 509,
iast_FULL (747.389 µs) : 725, 770
. : milestone, 747,
iast_GLOBAL (553.401 µs) : 531, 576
. : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (512.979 µs) : 491, 534
. : milestone, 513,
iast_INACTIVE (467.411 µs) : 445, 489
. : milestone, 467,
iast_TELEMETRY_OFF (496.874 µs) : 475, 519
. : milestone, 497,
tracing (452.252 µs) : 431, 473
. : milestone, 452,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~a938c8e65e, baseline=1.47.0-SNAPSHOT~19ce7f1a2a
dateFormat X
axisFormat %s
section baseline
no_agent (1.349 ms) : 1329, 1370
. : milestone, 1349,
appsec (1.742 ms) : 1718, 1766
. : milestone, 1742,
appsec_no_iast (1.761 ms) : 1737, 1785
. : milestone, 1761,
iast (1.506 ms) : 1482, 1530
. : milestone, 1506,
profiling (1.493 ms) : 1469, 1517
. : milestone, 1493,
tracing (1.485 ms) : 1459, 1510
. : milestone, 1485,
section candidate
no_agent (1.369 ms) : 1349, 1389
. : milestone, 1369,
appsec (1.744 ms) : 1720, 1767
. : milestone, 1744,
appsec_no_iast (1.761 ms) : 1737, 1786
. : milestone, 1761,
iast (1.52 ms) : 1495, 1546
. : milestone, 1520,
profiling (1.581 ms) : 1557, 1605
. : milestone, 1581,
tracing (1.488 ms) : 1463, 1512
. : milestone, 1488,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~a938c8e65e, baseline=1.47.0-SNAPSHOT~19ce7f1a2a
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.373 ms) : 2330, 2417
. : milestone, 2373,
iast (2.114 ms) : 2059, 2169
. : milestone, 2114,
iast_GLOBAL (2.149 ms) : 2094, 2204
. : milestone, 2149,
profiling (1.994 ms) : 1950, 2039
. : milestone, 1994,
tracing (1.94 ms) : 1898, 1982
. : milestone, 1940,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.355 ms) : 2312, 2398
. : milestone, 2355,
iast (2.114 ms) : 2059, 2169
. : milestone, 2114,
iast_GLOBAL (2.17 ms) : 2114, 2226
. : milestone, 2170,
profiling (1.976 ms) : 1932, 2020
. : milestone, 1976,
tracing (1.951 ms) : 1909, 1993
. : milestone, 1951,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~a938c8e65e, baseline=1.47.0-SNAPSHOT~19ce7f1a2a
dateFormat X
axisFormat %s
section baseline
no_agent (15.606 s) : 15606000, 15606000
. : milestone, 15606000,
appsec (15.081 s) : 15081000, 15081000
. : milestone, 15081000,
iast (18.906 s) : 18906000, 18906000
. : milestone, 18906000,
iast_GLOBAL (17.627 s) : 17627000, 17627000
. : milestone, 17627000,
profiling (15.137 s) : 15137000, 15137000
. : milestone, 15137000,
tracing (15.036 s) : 15036000, 15036000
. : milestone, 15036000,
section candidate
no_agent (15.491 s) : 15491000, 15491000
. : milestone, 15491000,
appsec (15.179 s) : 15179000, 15179000
. : milestone, 15179000,
iast (18.868 s) : 18868000, 18868000
. : milestone, 18868000,
iast_GLOBAL (18.548 s) : 18548000, 18548000
. : milestone, 18548000,
profiling (15.222 s) : 15222000, 15222000
. : milestone, 15222000,
tracing (14.698 s) : 14698000, 14698000
. : milestone, 14698000,
|
a938c8e
to
8585b4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]