Apply suggestions from code review

Co-authored-by: Emmett Butler <[email protected]>
DataDog · Sep 8, 2023 · 57317e6 · 57317e6
1 parent 6a892fa
commit 57317e6
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 14 deletions.
diff --git a/ddtrace/__init__.py b/ddtrace/__init__.py
@@ -18,7 +18,7 @@
 from ._logger import configure_ddtrace_logger
 
 
-# configure ddtrace logger before other modules log indeed
+# configure ddtrace logger before other modules log
 configure_ddtrace_logger()  # noqa: E402
 
 from ddtrace.internal import telemetry
@@ -46,15 +46,6 @@
 # a global tracer instance with integration settings
 tracer = Tracer()
 
-
-# The telemetry writer is not started until data is queued but this creates a
-# problem for CPython 3.12 which disallows thread creation at interpreter
-# finalization. In order to support 3.12, we start the writer upon initialization.
-# See https://github.com/python/cpython/pull/104826.
-if sys.version_info >= (3, 12):
-    telemetry.telemetry_writer.enable()
-
-
 __all__ = [
     "patch",
     "patch_all",

diff --git a/ddtrace/tracer.py b/ddtrace/tracer.py
@@ -75,9 +75,6 @@
 from typing import TypeVar
 
 
-# DELETEME: workaround to get circleci tests working
-
-
 log = get_logger(__name__)
 
 

diff --git a/hatch.toml b/hatch.toml
@@ -29,7 +29,7 @@ dependencies = [
     "flake8-rst-docstrings",
     "flake8-isort",
     "pygments",
-    "riot==0.18.0",
+    "riot==0.19.0",
 ]
 
 [envs.lint.scripts]
Original file line number	Diff line number	Diff line change
Expand Up		@@ -75,9 +75,6 @@
		from typing import TypeVar


		# DELETEME: workaround to get circleci tests working


		log = get_logger(__name__)


Expand Down