0.7.2-beta3: static-dev -> static #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for KMD chain minsigs to count nota tx as valid nota is 13, but for assetchains (ACs) it could be 7 or 11, depends on current height. this change allows to log how much valid signatures exists in nota tx candidate. for example this nota tx: https://pirate.explorer.dexstats.info/tx/32023e1e396ce5a7ba00bd3f6bc7d619c92bce052cf1b5fc2081b30466004124 in PIRATE chain have only 11 valid signatures: ``` 2022-06-24 19:51:29 [PIRATE] ht.1957772 txi.1 signedmask.100400000382e5 numvins.13 numvalid.11 numvouts.2 <<<<<<<<<<< notarized ``` as the following signatures/keys: ``` RGdxqk4hSBtGX9XxdBNMEKuupigrPra5Ju (pbca26_NA, S5) RLqnbAwfucQEcSzcBXEXAavLTtL1FrWxqJ (webworker01_NA, S5) ``` doesn't exists in S6, but tx anyway counted as valid nota: ``` [PIRATE] matched.1 VALID (PIRATE) MoM.af0b2f2372dd85a1074651fcf775076679668a35b7a16236628095a885b02b34 [40] CCid.0 [PIRATE] ht.1957772 NOTARIZED.1957764 PIRATE.0000000037bf4b6de7ab49c7a332e5f02fcd98a12f4c75106159c5b89381cd0c KMDTXID.11216cfb3fed63a9bd0d44672f983d671b5fe3797de96a4feb5c87b1a238d769 lens.(111 114) MoM.af0b2f2372dd85a1074651fcf775076679668a35b7a16236628095a885b02b34 40 ``` bcs 11 sigs is allowed for ACs too.
- KomodoPlatform/komodo#486 Also we get rid of LastTip() calls in this PR, changed them to Tip().
Backport of zcash/zcash#5853 to our codebase.
- KomodoPlatform/komodo#559 Tests (gtest, etc.) needs additional changes to build.
Issue: if we will try to build KomodoOcean with CXXFLAGS='-g -O0' we will get the following error during linkage: usr/bin/ld: libbitcoin_util.a(libbitcoin_util_a-util.o): in function `__static_initialization_and_destruction_0(int, int)': /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nStakedDecemberHardforkTimestamp' /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nS4Timestamp' /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nS5Timestamp' /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:19: undefined reference to `nS6Timestamp' /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nDecemberHardforkHeight' /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nS4HardforkHeight' /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nS5HardforkHeight' /usr/bin/ld: /home/decker/KomodoOcean/src/komodo_hardfork.h:20: undefined reference to `nS6HardforkHeight' So, we need to include komodo_hardfork.cpp into libbitcoin_util_a_SOURCES or delete include of komodo_hardfork.h from komodo_globals.h.
to avoid the following errors: /usr/bin/ld: depends/x86_64-unknown-linux-gnu/lib/libgmp.a(invert_limb.o): warning: relocation against `__gmpn_invert_limb_table' in read-only section `.text' /usr/bin/ld: warning: creating DT_TEXTREL in a PIE when build with 11.2.0 (Ubuntu 22.04.1 LTS, etc.)
backport of dimxy/komodo#129 to our codebase.
refactoring #559 pr backport
0.7.2-beta3: static-experimental -> static-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.