-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added types for pageclip
#72059
base: master
Are you sure you want to change the base?
Added types for pageclip
#72059
Conversation
@max-programming Thank you for submitting this PR! This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72059,
"author": "max-programming",
"headCommitOid": "91dca8d7c7d6c7966090df6d414c8a8ce18d0a97",
"mergeBaseOid": "84eb4f02e3dc9175c73bf56ed70f9b83a7bf5dae",
"lastPushDate": "2025-02-26T15:40:27.000Z",
"lastActivityDate": "2025-02-28T22:13:44.000Z",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "pageclip",
"kind": "add",
"files": [
{
"path": "types/pageclip/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/pageclip/index.d.ts",
"kind": "definition"
},
{
"path": "types/pageclip/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/pageclip/pageclip-tests.ts",
"kind": "test"
},
{
"path": "types/pageclip/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"max-programming"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "RyanCavanaugh",
"date": "2025-02-28T22:13:44.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2685446714,
"ciResult": "pass"
} |
🔔 @max-programming — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
@max-programming: Everything looks good here. I am ready to merge this PR (at 91dca8d) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.