Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently any formatting inside
workspace.members
is destroyed. Notably this means that aCargo.toml
with a trailing comma in this member can never be correctly formatted with trailing multiline commas enabled:This problem is exacerbated by the fact that the test
sort::toml_edit_check
, which would otherwise catch this issue, is negated: it checks that the workspace example is changed, which it is: the exampleis modified to
which is different. This is an unusual output format, but that's okay, because when running
cargo sort
for real, it will then immediately be reformatted back intoAdditionally, this issue can only appear in projects in which a
tomlfmt.toml
is present. This is because, contrary to documentation,multiline_trailing_comma
is actuallyfalse
by default.This PR:
sort::sort_array
to not throw away the trailing commamultiline_trailing_comma
totrue
to match the documentation