Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Exclusive Accordion to web-features id #14

Merged
merged 2 commits into from
May 25, 2024

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Apr 5, 2024

@foolip
Copy link
Contributor Author

foolip commented Apr 5, 2024

@SachaG would you prefer a new webFeatures field?

@@ -35,6 +35,7 @@
title: Chrome Platform Status
tags:
- features
- web-features:details-name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe it should be its own separate field? It's a bit weird to use the tags field for that?

@SachaG
Copy link
Member

SachaG commented May 11, 2024

@SachaG would you prefer a new webFeatures field?

Yes that would make more sense to me. In fact I think ideally we would just use the web feature id as the canonical id field, but that might not be practical for backwards-compatibility reasons.

@SachaG
Copy link
Member

SachaG commented May 11, 2024

Maybe we could name the field something like webFeaturesId, or wfId? web-features by itself doesn't really communicate the fact that it's a canonical ID?

@foolip
Copy link
Contributor Author

foolip commented May 22, 2024

@SachaG webFeaturesId works for me, it's pretty explicit and easy to search for. I'll update this PR to show what it'd look like.

@SachaG SachaG merged commit 48c9078 into Devographics:main May 25, 2024
@SachaG
Copy link
Member

SachaG commented May 25, 2024

1 done, 678 to go! (I'm guessing, I didn't count…)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants