Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Global status bits #114

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

LeandroMartinsdS
Copy link
Contributor

Abstract the global status bits using the hardware interface.

Add PMAC_HARDWARE_PROB for PowerPMAC.
The AbortAll is not being used to define a "Hardware problem" because the PowerPMAC permits to abort just some of the coordinate systems, this is useful in cases which more than one system is controlled by the same controller, and just one should be affected by the Abort input - e.g. an air-bearing stage.

@LeandroMartinsdS LeandroMartinsdS linked an issue Oct 27, 2023 that may be closed by this pull request
@LeandroMartinsdS LeandroMartinsdS added this to the R2-6-1 milestone Nov 7, 2023
@LeandroMartinsdS LeandroMartinsdS self-assigned this Nov 7, 2023
Copy link

@JamesOHeaDLS JamesOHeaDLS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I only have the 1 suggestion about comments

Add PMAC_HARDWARE_PROB for PowerPMAC
Add description for each global status bits, together with the PowerPMAC
error
Add comment to explain why PMAC_GSTATUS_ABORTALL is not included in
PMAC_HARDWARE_PROB
@LeandroMartinsdS LeandroMartinsdS force-pushed the 113-Fix-global-status-bits-powerpmac branch from 347e517 to 426f485 Compare November 13, 2023 11:52
@LeandroMartinsdS LeandroMartinsdS merged commit 6d8a7c0 into dls-master Nov 15, 2023
@LeandroMartinsdS LeandroMartinsdS deleted the 113-Fix-global-status-bits-powerpmac branch November 15, 2023 16:07
@LeandroMartinsdS LeandroMartinsdS mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global status bits doesn't support PowerPMAC
2 participants