Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX Refactor - 3 #42

Open
3 tasks
lucifercr07 opened this issue Oct 4, 2024 · 6 comments
Open
3 tasks

UX Refactor - 3 #42

lucifercr07 opened this issue Oct 4, 2024 · 6 comments
Assignees
@pawansoni007

Comments

@lucifercr07
Copy link
Contributor

lucifercr07 commented Oct 4, 2024 •
edited
Loading

Changes to be done:

  • Add placeholder in search box, for the user to know what the search is for. Like "Search Commands"
  • Add some bottom padding which is equal to the top navbar, this would provide some breathing space to the UI and look more balanced.
  • Show all command entries when the search box is in empty/initial state.
@pawansoni007
Copy link

Can you assign this to me @lucifercr07

@Sama-004
Copy link
Contributor

Sama-004 commented Oct 5, 2024

i can take this up. Also can we use shadcn components? https://ui.shadcn.com/docs/components/input

@lucifercr07
Copy link
Contributor Author

@pawansoni007 assigned, thanks for contributing.

@KaviiSuri
Copy link
Contributor

@lucifercr07 can you add one additional requirement here? it seems like we just show blank results when nothiing is searched for. we should show all entries. so it doesn't look empty.

@lucifercr07
Copy link
Contributor Author

@KaviiSuri have added below to description:

Show all command entries when the search box is in empty/initial state.

cc: @pawansoni007

pawansoni007 added a commit to pawansoni007/playground-web that referenced this issue Oct 6, 2024
@pawansoni007
Fix: UX Refactor - 3 (DiceDB#42) and SearchBox Optimization
9367028 
UX Refactor (DiceDB#42):
- Add placeholder in search box
- Add bottom padding equal to top navbar for balanced UI spacing
- Show all command entries when the search box is in empty/initial state.

SearchBox Optimization (IMPORTANT):
- Fix: SearchBox re-rendering every second due to usePlayground custom hook's timer
- Memoize SearchBox to prevent unnecessary updates
- Decouple from custom hook's timer updates
@pawansoni007 pawansoni007 mentioned this issue Oct 6, 2024
Open
@pawansoni007
Copy link

#54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawansoni007 pawansoni007

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lucifercr07 @KaviiSuri @Sama-004 @pawansoni007