Fixed multiwindow closing issue again #3588
Open
+34
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have to be careful not to break semver here unfortunately, so the interfaces need to remain the same but the internal details can change. IE we need to take Rc even if we downgrade it internally. I'll take a look at tweaking that on this PR. |
|
The multi-window example works for me on main - is there a particular repro you have? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like I explained in #3499 there is this issue where when creating a new window it cannot be closed again. This is due to references still pointing to the DesktopContext after being removed from webviews in app.rs. They themselves also cannot be dropped and this is not only because of the self referential structure. The problem has not been fixed with my previous pull request as half of it was simply ignored: If the DesktopContext Rc reference is upgraded again and added to other Structs it obviously cannot be dropped. Please test the examples. Also note that this fixes it for linux. For windows only partially.
Furthermore what I have noticed was that the issue was made worse because the main window cannot even be closed anymore because of the window decoration buttons not working - but this has probably nothing to do with this I'm just pointing it out...