Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(permissions): add use_external_sounds #997

Merged
merged 5 commits into from
May 22, 2023
Merged

feat(permissions): add use_external_sounds #997

merged 5 commits into from
May 22, 2023

Conversation

onerandomusername
Copy link
Member

Summary

implements discord/discord-api-docs#6039

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Apr 6, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Apr 6, 2023
@shiftinv shiftinv changed the title feat: add use_external_sounds permission feat(permissions): add use_external_sounds Apr 22, 2023
@shiftinv shiftinv added s: waiting for api/docs Issue/PR is waiting for API support/documentation and removed s: waiting for api/docs Issue/PR is waiting for API support/documentation labels Apr 22, 2023
@shiftinv
Copy link
Member

shiftinv commented Apr 28, 2023 •
edited
Loading

We can probably merge this without continuing to wait for the api-docs merge, it's been almost a month now.

@onerandomusername onerandomusername force-pushed the feat/use-external-sounds branch from afa8c90 to bf59093 Compare May 7, 2023 00:11
@shiftinv shiftinv removed the s: waiting for api/docs Issue/PR is waiting for API support/documentation label May 22, 2023
@shiftinv shiftinv enabled auto-merge (squash) May 22, 2023 14:45
@shiftinv shiftinv merged commit 6d82746 into DisnakeDev:master May 22, 2023
@shiftinv shiftinv deleted the feat/use-external-sounds branch May 22, 2023 14:49
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

@Skelmis Skelmis Skelmis approved these changes

Assignees
No one assigned
Labels
t: api support Support of Discord API features t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.
3 participants
@onerandomusername @shiftinv @Skelmis