Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 3.6 + bump ember-app-scheduler to fix deprecations #178

Merged
merged 2 commits into from
Dec 21, 2018
Merged

Update to 3.6 + bump ember-app-scheduler to fix deprecations #178

merged 2 commits into from
Dec 21, 2018

Conversation

cibernox
Copy link
Contributor

@cibernox cibernox commented Dec 20, 2018 •
edited by snewcomer
Loading

Bumping ember-app-scheduler is required for this addon to run in 3.6 without deprecations.

ember-app-scheduler/ember-app-scheduler@d56652e

@cibernox cibernox force-pushed the update-routes-scroll branch from 4537723 to 5708192 Compare December 20, 2018 21:16
@cibernox cibernox changed the title Update to 3.6 + bump ember-app-scheduler specifically Update to 3.6 + bump ember-app-scheduler to fix deprecations Dec 20, 2018
snewcomer
snewcomer approved these changes Dec 20, 2018
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✂️ ⚠️

@cibernox
Copy link
Contributor Author

@yowainwright If you could merge and cut a new release, that would helo fix the failing test suite in ember-animated.

@snewcomer snewcomer merged commit ae210bb into DockYard:master Dec 21, 2018
@snewcomer
Copy link
Collaborator

May have merged too early. Didn't realize I couldn't cut a release. I'll wait for Jeff!

FYI - Saw the same issue when upgrading our app to 3.6 as well so thanks Miguel!

@cibernox cibernox deleted the update-routes-scroll branch December 21, 2018 16:14
@yowainwright
Copy link
Contributor

yowainwright commented Dec 21, 2018 •
edited
Loading

@cibernox @snewcomer looking.

Update: The core code updates in this PR are automated with Greenkeeper and by running yarn update. The diff of this PR is large although the necessary change is an update to the dependency ember-source in package.json. The other dependency updates are/were fuzzy matched (when running yarn, this repo was already getting the highest version of the other updated dependencies)—which is why Greenkeeper did not submit PRs for dependency updates.

I'm happy to be wrong if I'm misunderstanding/misreading something. 😊

Please update CONTRIBUTING.md to communicate the Greenkeeper notes above. I apologize that the Greenkeeper workflow wasn't documented in a CONTRIBUTING.md or the README.

Thanks for the work @cibernox and the review @snewcomer!

This seems like a patch version bump. Do you agree @snewcomer?

@yowainwright
Copy link
Contributor

I know/assume that doing a bunch of great work and reading a comment about Greenkeeper is no fun—sorry 😑.

@snewcomer
Copy link
Collaborator

Yep patch it! THanks a ton @yowainwright!

@snewcomer
Copy link
Collaborator

@yowainwright you the man! Thanks a lot. Allowed us to easily update.

@yowainwright
Copy link
Contributor

@cibernox This CONTRIBUTING is AWESOME btw. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cibernox @snewcomer @yowainwright