Skip to content
This repository has been archived by the owner on Oct 3, 2019. It is now read-only.

Configurar integração contínua CI e Análise estática de código #80

Closed
3 tasks done
egewarth opened this issue Mar 26, 2018 · 17 comments
Closed
3 tasks done
Assignees
Labels
0-DevOps DevOps do projeto 0-EPS Issues destinadas à equipe de EPS 5-Intermediário Issue de nível intermediário no projeto.
Milestone

Comments

@egewarth
Copy link
Collaborator

egewarth commented Mar 26, 2018

Nessa issue devera ser feito:

@egewarth egewarth added 0-EPS Issues destinadas à equipe de EPS 5-Intermediário Issue de nível intermediário no projeto. 0-DevOps DevOps do projeto labels Mar 26, 2018
@egewarth egewarth added this to the Sprint 2 milestone Mar 26, 2018
@eliseuegewarth eliseuegewarth changed the title Travis CI Configurar integração contínua CI e Análise estática de código Mar 27, 2018
eliseuegewarth added a commit that referenced this issue Mar 27, 2018
… de código no README.md

Signed-off-by: Eliseu Egewarth <[email protected]>
@eliseuegewarth
Copy link
Member

eliseuegewarth commented Mar 27, 2018

Devemos definir quais métricas serão coletadas pelo codeClimate afim de definir as métricas que serão analisadas e mantidas no projeto.
Votem nas opções que vocês acharem mais adequadas e se possível, comentem seus argumentos.
@fga-gpp-mds/eps-agr

@eliseuegewarth
Copy link
Member

Métrica:

  • Similar blocks of code

@eliseuegewarth
Copy link
Member

Métrica:

  • Return statements

@eliseuegewarth
Copy link
Member

Métrica:

  • Nested control flow

@eliseuegewarth
Copy link
Member

Métrica:

  • Method length

@eliseuegewarth
Copy link
Member

Métrica:

  • Method count

@eliseuegewarth
Copy link
Member

Métrica:

  • Method complexity

@eliseuegewarth
Copy link
Member

Métrica:

  • Identical blocks of code

@eliseuegewarth
Copy link
Member

Métrica:

  • File length

@eliseuegewarth
Copy link
Member

Métrica:

  • Complex logic

@eliseuegewarth
Copy link
Member

Métrica:

  • Argument count

@gag2502
Copy link
Collaborator

gag2502 commented Mar 27, 2018

Ao selecionar minhas preferências, levei em conta o nível de conhecimento atual da tecnologias. Por ser um estágio inicial, talvez aplicar as boas práticas de técnicas de programação pode não ser tão fácil.

@alvesisaque
Copy link
Member

Acredito que devemos colocar para a próxima sprint a folha de estilo. Isso vai ajudar a organizar, na comunicação e o aproveitamento de código.

@egewarth
Copy link
Collaborator Author

Ao dar meu feedback levei em consideração que não temos um conhecimento da linguagem, mas levei em conta os comentarios do @LucasAmoedo sobre replicação de código, por isso não aprovei a analise de blocos de código similares.

@LucasAmoedo
Copy link

Meio de intruso:

Se vocês vão aplicar folha de estilo, permitam-me recomendar a da Airbnb para React Native. É possível usar o eslint para testar automaticamente (inclusive fazendo o Travis falhar se algo não estiver de acordo). Como ponto negativo, ela pode ser bastante chata. Bastante. E um pouco difícil. Mas ajuda a padronizar código.

@gag2502
Copy link
Collaborator

gag2502 commented Mar 27, 2018

@LucasAmoedo Obrigada pela dica @LucasAmoedo 👍 😊 👏

eliseuegewarth added a commit that referenced this issue Mar 27, 2018
… de código no README.md

Signed-off-by: Eliseu Egewarth <[email protected]>
eliseuegewarth added a commit that referenced this issue Mar 27, 2018
eliseuegewarth added a commit that referenced this issue Mar 27, 2018
eliseuegewarth added a commit that referenced this issue Mar 27, 2018
eliseuegewarth added a commit that referenced this issue Mar 27, 2018
eliseuegewarth added a commit that referenced this issue Mar 27, 2018
eliseuegewarth added a commit that referenced this issue Mar 27, 2018
@eliseuegewarth
Copy link
Member

Das métricas de código listadas e votadas acima foram definidas:

  • Consideradas:

  • Return statements

  • Nested control flow

  • Method length

  • Method complexity

  • Identical blocks of code

  • File length

  • Complex logic

  • Desconsideradas:

  • Similar blocks of code

  • Method count

  • Argument count

eliseuegewarth added a commit that referenced this issue Mar 30, 2018
… de código no README.md

Signed-off-by: Eliseu Egewarth <[email protected]>
eliseuegewarth added a commit that referenced this issue Mar 30, 2018
eliseuegewarth added a commit that referenced this issue Mar 30, 2018
eliseuegewarth added a commit that referenced this issue Mar 30, 2018
eliseuegewarth added a commit that referenced this issue Mar 30, 2018
eliseuegewarth added a commit that referenced this issue Mar 30, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
… de código no README.md

Signed-off-by: Eliseu Egewarth <[email protected]>
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
Signed-off-by: Eliseu Egewarth <[email protected]>
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
@eliseuegewarth eliseuegewarth mentioned this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
… de código no README.md

Signed-off-by: Eliseu Egewarth <[email protected]>
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
Signed-off-by: Eliseu Egewarth <[email protected]>
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
Signed-off-by: Eliseu Egewarth <[email protected]>
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
eliseuegewarth added a commit that referenced this issue Apr 1, 2018
Signed-off-by: Eliseu Egewarth <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0-DevOps DevOps do projeto 0-EPS Issues destinadas à equipe de EPS 5-Intermediário Issue de nível intermediário no projeto.
Projects
None yet
Development

No branches or pull requests

5 participants