This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add payment support for kv storage #9298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swatanabe-b1
reviewed
Jul 9, 2020
libraries/chain/apply_context.cpp
Outdated
| void apply_context::update_disk_usage( account_name account, int64_t disk_delta, const storage_usage_trace& trace ) { | ||
|
|
||
| if (disk_delta > 0 && !privileged) { | ||
| EOS_ASSERT(receiver == act->account, subjective_block_production_exception, |
There was a problem hiding this comment.
This should not be a subjective failure. The similar check in update_db_usage is a subjective mitigation for before RAM_RESTRICTIONS is activated. Since DISK in new, we don't need subjective mitigations and can always apply the restriction. The actual check that you should copy is in exec_one.
There was a problem hiding this comment.
The behaviour of the check in exec_one is slightly different from the subjective check in update_db_usage. Unless we've decided that that was a mistake it would be better to change exec_one, so the behaviour of DISK matches RAM.
libraries/chain/apply_context.cpp
Outdated
| @@ -50,6 +50,32 @@ apply_context::apply_context(controller& con, transaction_context& trx_ctx, uint | |||
| context_free = trace.context_free; | |||
| } | |||
|
|
|||
| template <typename Excpetion> | |||
libraries/chain/apply_context.cpp
Outdated
| counter = 0; | ||
| } | ||
| if (entry.delta > 0 && entry.account != receiver) { | ||
| EOS_ASSERT(not_in_notify_context, Excpetion, |
libraries/chain/apply_context.cpp
Outdated
| "${account}", | ||
| ("resource", resource) | ||
| ("account", entry.account)); | ||
| EOS_ASSERT(has_authorization(entry.account), Excpetion, |
# Conflicts: # libraries/chain/include/eosio/chain/exceptions.hpp
jeffreyssmith2nd
approved these changes
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Allow application developers to choose who pays for resources (feature parity with multi-index table functionality).
EPE-218
Change Type
Select ONE
Consensus Changes
API Changes
Documentation Additions