Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

[docs] dev branch: add how to local testnet with consensus #9904

Merged
merged 6 commits into from
Jan 19, 2021
Merged

[docs] dev branch: add how to local testnet with consensus #9904

merged 6 commits into from
Jan 19, 2021

Conversation

iamveritas
Copy link
Contributor

@iamveritas iamveritas commented Jan 13, 2021 •
edited
Loading

initial sister PR for #9825 (already merged)
new sister PR #9921

adds how to start local testnet with consensus

only file docs/01_nodeos/02_usage/03_development-environment/10_local-single-node-testnet-consensus.md was added, the rest of the changes are necessary to make room for it in the existing documentation.

resolves #7180

@iamveritas iamveritas added the documentation Requires attention from documentation team. e.g. documentation is expected to be generated. label Jan 13, 2021
@iamveritas iamveritas requested a review from lparisc January 13, 2021 16:05
@iamveritas iamveritas self-assigned this Jan 13, 2021
@iamveritas iamveritas requested review from bobgt and halsaphi January 13, 2021 16:05
lparisc
lparisc suggested changes Jan 13, 2021
View reviewed changes
@iamveritas iamveritas requested a review from lparisc January 15, 2021 00:10
@iamveritas iamveritas requested a review from lparisc January 18, 2021 11:49
@iamveritas iamveritas mentioned this pull request Jan 18, 2021
Merged
bobgt
bobgt approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@bobgt bobgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. I added a few suggestions.

@iamveritas iamveritas requested a review from lparisc January 19, 2021 17:16
@iamveritas iamveritas merged commit 6a51390 into develop Jan 19, 2021
@kj4ezj kj4ezj deleted the docs/dev-local-testnet branch July 19, 2021 17:40
@vladtr vladtr mentioned this pull request Jun 23, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lparisc lparisc lparisc approved these changes

@bobgt bobgt bobgt approved these changes

@halsaphi halsaphi Awaiting requested review from halsaphi

Assignees

@iamveritas iamveritas

Labels
documentation Requires attention from documentation team. e.g. documentation is expected to be generated.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iamveritas @lparisc @bobgt