Removed redundant LpInvertRequirementError and added unit test for ge…

…tCoeff when matrix is rowwise
ERGO-Code · Feb 27, 2025 · ca0d691 · ca0d691
1 parent dac434c
commit ca0d691
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/check/TestLpValidation.cpp b/check/TestLpValidation.cpp
@@ -389,6 +389,10 @@ TEST_CASE("LP-validation", "[highs_data]") {
   REQUIRE(highs.getCoeff(check_row, check_col, check_value) ==
           HighsStatus::kOk);
   REQUIRE(check_value == to_value);
+  REQUIRE(highs.ensureRowwise() == HighsStatus::kOk);
+  REQUIRE(highs.getCoeff(check_row, check_col, check_value) ==
+          HighsStatus::kOk);
+  REQUIRE(check_value == to_value);
 }
 
 TEST_CASE("LP-row-index-duplication", "[highs_data]") {

diff --git a/src/Highs.h b/src/Highs.h
@@ -1664,7 +1664,6 @@ class Highs {
   HighsStatus checkOptimality(const std::string& solver_type,
                               HighsStatus return_status);
   HighsStatus invertRequirementError(std::string method_name) const;
-  HighsStatus lpInvertRequirementError(std::string method_name) const;
 
   HighsStatus handleInfCost();
   void restoreInfCost(HighsStatus& return_status);

diff --git a/src/lp_data/HighsInterface.cpp b/src/lp_data/HighsInterface.cpp
@@ -2486,14 +2486,6 @@ HighsStatus Highs::invertRequirementError(std::string method_name) const {
   return HighsStatus::kError;
 }
 
-HighsStatus Highs::lpInvertRequirementError(std::string method_name) const {
-  assert(!ekk_instance_.status_.has_invert);
-  if (model_.isMip() || model_.isQp()) return HighsStatus::kOk;
-  highsLogUser(options_.log_options, HighsLogType::kError,
-               "No LP invertible representation for %s\n", method_name.c_str());
-  return HighsStatus::kError;
-}
-
 HighsStatus Highs::handleInfCost() {
   HighsLp& lp = this->model_.lp_;
   if (!lp.has_infinite_cost_) return HighsStatus::kOk;