Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cppcheck performance passedByValue warnings #2181

Conversation

MaximSmolskiy
Copy link

No description provided.

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.

Please upload report for BASE (check-2181@4c783d9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/util/HighsUtils.cpp 40.00% 3 Missing ⚠️
src/io/HighsIO.cpp 0.00% 2 Missing ⚠️
src/lp_data/HighsDebug.cpp 0.00% 2 Missing ⚠️
src/lp_data/HighsIis.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             check-2181    #2181   +/-   ##
=============================================
  Coverage              ?   78.81%           
=============================================
  Files                 ?      345           
  Lines                 ?    83174           
  Branches              ?        0           
=============================================
  Hits                  ?    65551           
  Misses                ?    17623           
  Partials              ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jajhall jajhall changed the base branch from latest to check-2181 February 15, 2025 22:38
@jajhall jajhall merged commit 1bbc7df into ERGO-Code:check-2181 Feb 15, 2025
117 of 119 checks passed
@jajhall
Copy link
Member

jajhall commented Feb 15, 2025

I understand your motivation for making these changes. Passing strings by value is of no great importance, but I see that there are a few vectors that you've picked up on.

I've merged it into a branch rather than latest so I can study your changes and fix the formatting

@MaximSmolskiy MaximSmolskiy deleted the fix_cppcheck_performance_passedByValue_warnings branch February 15, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants