Fix 2188 #2200
Merged
Fix 2188 #2200
+71
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update model_status when checkOptimality fails
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## latest #2200 +/- ##
==========================================
+ Coverage 78.76% 78.79% +0.03%
==========================================
Files 343 343
Lines 82988 83009 +21
==========================================
+ Hits 65363 65405 +42
+ Misses 17625 17604 -21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the fix from @odow more elegant by modifying
model_status_inHighs::checkOptimality, setting it toHighsModelStatus::kUnknown;unless the primal/dual infeasibilities are excessive, when it's set toHighsModelStatus::kSolveError.