Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not change function argument names when decorator preserve_float_dtype is used #2645

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

schlunma
Copy link
Contributor

@schlunma schlunma commented Jan 27, 2025

Description

See #2641 (comment).


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@schlunma schlunma added the bug Something isn't working label Jan 27, 2025
@schlunma schlunma added this to the v2.12.0 milestone Jan 27, 2025
@schlunma schlunma requested a review from bouweandela January 27, 2025 13:07
@schlunma schlunma assigned schlunma and unassigned schlunma Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.99%. Comparing base (1e34201) to head (ccbc596).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2645      +/-   ##
==========================================
- Coverage   95.00%   94.99%   -0.01%     
==========================================
  Files         255      255              
  Lines       14824    14837      +13     
==========================================
+ Hits        14083    14094      +11     
- Misses        741      743       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schlunma schlunma changed the title Do not change argument names with decorator preserve_float_dtype Do not change function argument names when decorator preserve_float_dtype is used Jan 27, 2025
@bouweandela bouweandela merged commit 8f85fad into main Jan 30, 2025
7 checks passed
@bouweandela bouweandela deleted the better_decorator branch January 30, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants