Elements psbt updates #218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgriffiths
force-pushed
the
elements_pbst
branch
6 times, most recently
from
c4de62c to
fe658d7
Compare
jgriffiths
force-pushed
the
elements_pbst
branch
2 times, most recently
from
506fb93 to
e877af3
Compare
jgriffiths
force-pushed
the
elements_pbst
branch
2 times, most recently
from
9400bb1 to
5d8d667
Compare
jgriffiths
force-pushed
the
elements_pbst
branch
2 times, most recently
from
c40e9ad to
bd62939
Compare
jgriffiths
force-pushed
the
elements_pbst
branch
2 times, most recently
from
5ba78b1 to
ddcd0f0
Compare
Instead use two bitsets to track which keys we have already seen. Pull out subfield handling from PSBT_PULL_B to make this logic clearer.
Note I've added this with the scalar in the value and not the key as per the review on the Elements commit updating PSET.
Use these to implement the nested input/output accessor functions.
This more closely matches the transaction code however that refers to the (commitment to) the blinded issuance amount as just the amount which is not ideal. Also add missing Java wrappers for these calls.
…puts This gains us back e.g. the length checking for varbuffs and allows us to implement the logic to handle mutually exclusive members.
…offset elements only
Also add a test for global unknowns and fix unknown to represent a real key value when serialised.
SWIG doesn't handle macros that define functions correctly yet, so this is required to let SWIG work with our simplified struct macros.
jgriffiths
force-pushed
the
elements_pbst
branch
from
ddcd0f0 to
973bc70
Compare
|
Superseded with now merged PSBT/PSETv2 support, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Elements PSBT support to match the latest changes as per ElementsProject/elements#900.
Since that spec is not finalised - yet more changes may be required.