grpc: Silence the notification spam #7867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog-Fixed: grpc: We no longer log a warning if a notification does not have a handler
cdecker
force-pushed
the
202448-cln-grpc-silence
branch
from
22227ac to
7432c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were logging notifications for which we do not have a handler registered.
That worked until we introduced the wildcard subscription, which the grpc plugin
uses. With this the guarantee that for each subscribed topic we had a corresponding
handler is no longer true, and the warning doesn't really add any information
to the logs, so we just stop logging.
Closes #7836