Renepay use getroutes #8049
Draft
Renepay use getroutes #8049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lagrang3
force-pushed
the
renepay-use-askrene
branch
3 times, most recently
from
1062510 to
b2fcf5f
Compare
Lagrang3
force-pushed
the
renepay-use-askrene
branch
3 times, most recently
from
ac2e0b1 to
c2925cf
Compare
Lagrang3
force-pushed
the
renepay-use-askrene
branch
from
304bf67 to
313aecf
Compare
Changelog-Added: renepay: use external call to [askrene-]getroutes instead of computing routes internally. Signed-off-by: Lagrang3 <[email protected]>
Use askrene API to account for route-hints and blinded paths. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
The execution of the failure notification makes calls to askrene to disable or bias channels that have returned weird errors. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Remove unnecessary rpc call to waitblockheight at the default payment's ending. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Remove the MCF solver from renepay. Offload the route computation on askrene. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Use plugin_get_data API and make less use of the access to the global plugin state when possible. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Sending requests with batches allow us to avoid race conditions when the payment plugin goes to the next state before the sendpay RPC have not yet completed. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Use askrene-reserve API to lock-in the liquidity of the channels in use for pending payment route. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Use askrene-unreserve to remove reserved liquidity associated with routes that have completed, either by success or failure. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Make extensive use of rpc batches so that we ensure all request have been processed before the notification is closed as handled. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Use askrene-inform-channel to update the knowledge of the liquidity when a payment attempt fails. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Splig send routes into two steps: 1. reserve liquidity, 2. call sendpay Changelog-None Signed-off-by: Lagrang3 <[email protected]>
struct rpcaction: encapsulates the concept of an RPC action, ie. an RPC call object. It can be attached to an rpcbatch. Changelog-None. Signed-off-by: Lagrang3 <[email protected]>
Calling askrene-unreserve using rpcActions. Either: - after geting a fail notification, - or success notification, - or if the route destructor is called. Changelog-None Signed-off-by: Lagrang3 <[email protected]>
not supported by askrene Changelog-None Signed-off-by: Lagrang3 <[email protected]>
Lagrang3
force-pushed
the
renepay-use-askrene
branch
from
313aecf to
2f08e74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the MCF code from renepay. Routes are computed using getroutes instead.
Depends on #7985 (merged)
Replaces #7633 (closed)
It would be nice to have on top of #7963 "temporary layers" and #8072 "bias stacking"