Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fast_merkle_root and AssetId type #19

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Add fast_merkle_root and AssetId type #19

merged 3 commits into from
Sep 20, 2019

Conversation

stevenroose
Copy link
Member

@stevenroose stevenroose commented Apr 28, 2019 •
edited
Loading

Based on Elements' ComputeFastMerkleRoot.

@stevenroose stevenroose force-pushed the elementshash branch 3 times, most recently from 7b7d406 to 3fdcd5e Compare April 29, 2019 09:26
@stevenroose stevenroose changed the title WIP: Add fast_merkle_root implementation Add fast_merkle_root and AssetId type Apr 29, 2019
@stevenroose stevenroose force-pushed the elementshash branch 3 times, most recently from 87344d9 to 0b22844 Compare April 29, 2019 16:28
@stevenroose stevenroose mentioned this pull request Apr 29, 2019
Open
shesek added a commit to Blockstream/asset_registry that referenced this pull request Apr 30, 2019
@shesek
Implement new AssetId type and verification for contract hash commitment
84dad42 
Including updated tests with valid issuance commitments.

Based on ElementsProject/rust-elements#19
which is still unmerged, pulled via shesek/rust-elements#edge
@shesek
Copy link
Contributor

shesek commented May 16, 2019

Integrated into the registry project I'm working on, the implementation does seem correct now.

@shesek shesek mentioned this pull request Jun 21, 2019
Closed
@stevenroose stevenroose force-pushed the elementshash branch 2 times, most recently from 446f44c to 91a3f74 Compare September 20, 2019 15:09
apoelstra
apoelstra approved these changes Sep 20, 2019
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Easy to read, well commented, no allocations, no layer violations.

@apoelstra apoelstra merged commit 53b92d8 into ElementsProject:master Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apoelstra apoelstra apoelstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevenroose @shesek @apoelstra