Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tx history head/tail fix #3385

Merged
merged 8 commits into from
Jan 15, 2024
Merged

tx history head/tail fix #3385

merged 8 commits into from
Jan 15, 2024

Conversation

vsubhuman
Copy link
Contributor

No description provided.

@neuodev
Copy link
Contributor

neuodev commented Jan 12, 2024 •
edited
Loading

[autoscript] ⚠️ ruslan/tx-history-fix doesn't full our branch naming convention.
Should follow <tag>/<jira-ticket-id>/<short-name>

Details
  • <tag>: fix, feat, chore, refactor, test, ...
  • <jira-ticket-id>: The issue ID of JIRA all capital letters
  • <short-name>: A short and descriptive name for the branch

@vsubhuman vsubhuman changed the base branch from develop to ruslan/cip67-yoroi-lib January 12, 2024 21:41
@vsubhuman vsubhuman marked this pull request as ready for review January 15, 2024 06:49
Nebyt
Nebyt previously approved these changes Jan 15, 2024
View reviewed changes
yushih
yushih previously approved these changes Jan 15, 2024
View reviewed changes
Base automatically changed from ruslan/cip67-yoroi-lib to develop January 15, 2024 20:34
@vsubhuman vsubhuman dismissed stale reviews from yushih and Nebyt January 15, 2024 20:34

The base branch was changed.

@vsubhuman vsubhuman merged commit 53a1a11 into develop Jan 15, 2024
2 checks passed
@vsubhuman vsubhuman deleted the ruslan/tx-history-fix branch January 15, 2024 20:35
@sonarqube-yoroi
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vsubhuman vsubhuman mentioned this pull request Jan 22, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yushih yushih yushih left review comments

@Nebyt Nebyt Nebyt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.1.0 (swap, dynamic params, domain r...
Development

Successfully merging this pull request may close these issues.
4 participants
@vsubhuman @neuodev @yushih @Nebyt