-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: component token description consistency #10430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DitwanP
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍠✨🧹 Awesome, LGTM!
benelan
added a commit
that referenced
this pull request
Sep 30, 2024
…estone-estimates * origin/dev: (26 commits) test: fix `window.getComputedStyle` arguments (#10424) test(card): remove redundant spy and setup wrapper element (#10429) test(heading): avoid `newSpecPage` usage to ease Lumina migration (#10431) refactor(themed): drop broken, unused, regexp arg support (#10425) docs: component token description consistency (#10430) refactor: prevent mixed Sass mixed declaration warnings (#10426) deprecate: deprecate `enforce-ref-last-prop` rule (#10421) chore(actions): add custom `deprecate` type to semantic-pr check (#10427) chore(issue templates): add arcgis data pipelines to team dropdown (#10418) fix(tooltip): closed tooltips should not reappear (#10420) feat: add dashboard-graph (#10417) fix(input-time-zone): fix region mode quirks after update (#10413) fix(text-area): ensure border-color token doesn't override invalid styles (#10390) ci(changelog): add deprecation commits to changelog automation (#10346) fix: properly set aria attributes on components (#10404) feat: add parcel parameter (#10384) feat(alert): apply --calcite-alert-corner-radius to internal close button (#10388) feat(dialog, panel): Add css properties for background-color (#10387) fix: remove aria-disabled from components where necessary (#10374) feat(action-group, block, panel): add `menuPlacement` and `menuFlipPlacements` properties (#10249) ...
geospatialem
added a commit
that referenced
this pull request
Dec 17, 2024
**Related Issue:** #7180 ## Summary Provide consistency and alignment in our docs across the design system for component design tokens, also in alignment with our #10058 and #10430. 📚 Also of note, there was an extra `*` in the `navigation logo` [internal doc](https://next-preview.sites.afd.arcgis.com/calcite-design-system/components/navigation-logo/#styles).
benelan
pushed a commit
that referenced
this pull request
Feb 8, 2025
**Related Issue:** #7180 ## Summary Provide consistency and alignment in our docs across the design system for component design tokens, also in alignment with our #10058 and #10430. 📚 Also of note, there was an extra `*` in the `navigation logo` [internal doc](https://next-preview.sites.afd.arcgis.com/calcite-design-system/components/navigation-logo/#styles).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Issues relating to documentation updates only.
skip visual snapshots
Pull requests that do not need visual regression testing.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Provide consistency and alignment in our docs across the design system for component design tokens, also in alignment with our component token example PR. 📚