Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /book command on 1.20+ #6064

Merged
merged 3 commits into from
Feb 23, 2025
Merged

Fix /book command on 1.20+ #6064

merged 3 commits into from
Feb 23, 2025

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented Feb 23, 2025

Starting with 1.20, there are two different type of book metas, one for writeable and another for written. Since they are different types, the server silently rejects the setItemMeta call. Just copy over the relevant parts to the new meta.

Fixes #6030

Starting with 1.20, there are two different type of book metas, one for writeable and another for written. Since they are different types, the server silently rejects the setItemMeta call. Just copy over the relevant parts to the new meta.
@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels Feb 23, 2025
@JRoy JRoy added this to the 2.21.0 milestone Feb 23, 2025
@JRoy JRoy enabled auto-merge (squash) February 23, 2025 22:04
@JRoy JRoy merged commit bad79b7 into EssentialsX:2.x Feb 23, 2025
1 check passed
@JRoy JRoy deleted the fix/6030 branch February 23, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/book is not working properly
2 participants