Hangs on some zip files

[satazor]

Here's an example: http://jqueryui.com/resources/download/jquery-ui-1.10.0.custom.zip
CPU is at 100%.

Please note that in older versions, it was giving me signature error. But after upgrading, I'm getting this behaviour.

This bug has been reported in twitter/bower: bower/bower#225

I dunno if this is related to #8, probably is.

[EvanOxfeld]

In Node v0.9.6 CPU usage stays under 10%. Unfortunately unzip still hangs after writing AUTHORS.txt from the jquery zip.

[satazor]

Yes, in node v0.8.1.18 it also extracts AUTHORS.txt, though the CPU usage seems to be higher than the v0.9.8.

[EvanOxfeld]

I've tracked down the problem and am working on a fix for unzip to support more zip formats.

Right now unzip only handles zip files that store the compressed / uncompressed file size in the local file header immediately prior to a given file's data. The example jquery zip file stores the compressed and uncompressed file size values after the compressed data rather than in the local file headers.

[satazor]

Hmm does it still conform to the Zip spec or is it an invalid zip per say?

[EvanOxfeld]

It definitely conforms; the Zip spec is just wacky. There's a bit in the file header to signify whether or not the file size will be known at the start of inflation versus following.

[satazor]

Alright, looking forward to the fix!

[EvanOxfeld]

I have a fix that still needs cleanup. I'm targeting getting it published to npm tonight.

[ralphholzmann]

Thanks for the work on this @EvanOxfeld!

[anacronw]

thanks!

[EvanOxfeld]

This improvement is in unzip 0.1.3 and works in both Node 0.8 and 0.9. Unzip 0.1.3 should land in NPM shortly if it isn't there already.

In the meantime, please let me know if you run into any issues.

[EvanOxfeld]

If you installed unzip 0.1.3 from NPM within the last five hours, please delete it and install it again. You received a much larger archive than you should have - see #11.

[satazor]

@EvanOxfeld I'm not getting the end or error event when extracting. :(

[satazor]

In 0.0.4:

  writer.on('close', function() {
    self.emit("end");
    self.emit("close");
  });

In 0.1.x end was removed. Was this intentional?

[EvanOxfeld]

@satazor Checking the unzip.Extract stream for the 'close' event is correct. I removed unzip.Extract's 'end' event intentionally to conform to the Writable Stream spec. My understanding is that only streams that are readable should emit 'end' whereas streams that are writable should emit 'finish' and may emit 'close'.

Sorry for the confusion I probably caused, but I'm glad the issue has been resolved in Bower.

[satazor]

Alright, thank you!

[amakhrov]

Still hangs on some files (xlsx files produced by MS Office) :
https://dl.dropboxusercontent.com/u/39725868/xlsx.zip

It starts reading the file - 'entry' callback triggers a couple of times. And then hangs, producing 100% cpu load.
Strange enough that the old 0.0.4 version parses this file well.

Thanks

[lazdmx]

Still hangs on some files...

[RonWang]

Data point: also still hangs on some files...