Merge pull request #7996 from Expensify/Rory-FixDesktopBuild

[CP Stg] Add title and artifactName back in ElectronBuilder config (cherry picked from commit 2a40af5)
Expensify · Mar 4, 2022 · 4f71c95 · 4f71c95
1 parent f833a22
commit 4f71c95
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/...electronBuilder/electronBuilder.config.js → config/electronBuilder.config.js b/...electronBuilder/electronBuilder.config.js → config/electronBuilder.config.js
@@ -1,4 +1,4 @@
-const {version} = require('../../package.json');
+const {version} = require('../package.json');
 
 const isStaging = process.env.ELECTRON_ENV === 'staging';
 const isPublishing = process.argv.includes('--publish');
@@ -26,6 +26,8 @@ module.exports = {
         type: 'distribution',
     },
     dmg: {
+        title: 'New Expensify',
+        artifactName: 'NewExpensify.dmg',
         internetEnabled: true,
     },
     publish: [{

diff --git a/desktop/main.js b/desktop/main.js
@@ -17,6 +17,8 @@ const CONFIG = require('../src/CONFIG').default;
 
 const port = process.env.PORT || 8080;
 
+app.setName('New Expensify');
+
 /**
  * Electron main process that handles wrapping the web application.
  *

diff --git a/desktop/notarize.js b/desktop/notarize.js
@@ -1,5 +1,5 @@
 const {notarize} = require('electron-notarize');
-const electron = require('../config/electronBuilder/electronBuilder.config');
+const electron = require('../config/electronBuilder.config');
 
 exports.default = function notarizing(context) {
     const {electronPlatformName, appOutDir} = context;

diff --git a/scripts/build-desktop.sh b/scripts/build-desktop.sh
@@ -24,4 +24,4 @@ info ""
 title "Building Desktop App Archive Using Electron"
 info ""
 shift 1
-"$LOCAL_PACKAGES/electron-builder" --config config/electronBuilder/electronBuilder.config.js "$@"
+"$LOCAL_PACKAGES/electron-builder" --config config/electronBuilder.config.js "$@"
-Original file line number
+Diff line change
@@ Expand Up / @@ -17,6 +17,8 @@ const CONFIG = require('../src/CONFIG').default; @@
     const port = process.env.PORT || 8080;
+    app.setName('New Expensify');
     /**
      * Electron main process that handles wrapping the web application.
      *
@@ Expand Down @@