[HOLD for payment 2022-08-30] [$250] Web - Announce room - User time zone is displayed after page refresh

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com and login with expensifail account
2. Go to workspace and search for #announce
3. No time zone is above the compose box
4. Add a member to the workspace and go back to the announce room

Expected Result:

Don't see the time zone of any users in default rooms

Actual Result:

Time zone of that other user appears after refreshing the page

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.86-1
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers): [email protected] / Utest123 or Any expensifail account
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5663832_Recording__2368.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[puneetlath]

Hm, I would expect that in the announce room (or any room for that matter), you would never see timezone info for another user above the chat box. I'm going to change the expected result accordingly.

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[puneetlath]

Internal upwork job: https://www.upwork.com/ab/applicants/1551983550045458432/job-details
External upwork job: https://www.upwork.com/jobs/~0107cf3501d9c01c60

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

[melvin-bot]

Current assignee @puneetlath is eligible for the Exported assigner, not assigning anyone new.

[Santhosh-Sellavel]

Proposal

In this method adding a check !isChatRoom(report) would be enough.

App/src/libs/ReportUtils.js

Lines 319 to 329 in 92186e5

	function canShowReportRecipientLocalTime(personalDetails, report) {
	const reportParticipants = _.without(lodashGet(report, 'participants', []), sessionEmail);
	const participantsWithoutExpensifyEmails = _.difference(reportParticipants, CONST.EXPENSIFY_EMAILS);
	const hasMultipleParticipants = participantsWithoutExpensifyEmails.length > 1;
	const reportRecipient = personalDetails[participantsWithoutExpensifyEmails[0]];
	const reportRecipientTimezone = lodashGet(reportRecipient, 'timezone', CONST.DEFAULT_TIME_ZONE);
	return !hasMultipleParticipants
	&& reportRecipient
	&& reportRecipientTimezone
	&& reportRecipientTimezone.selected;
	}

[melvin-bot]

@puneetlath, @mananjadhav Huh... This is 4 days overdue. Who can take care of this?

[Santhosh-Sellavel]

@puneetlath Bump!

[melvin-bot]

@puneetlath, @mananjadhav 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[puneetlath]

@Santhosh-Sellavel yep, that seems like it would work. Let's do it.

[melvin-bot]

📣 @Santhosh-Sellavel You have been assigned to this job by @puneetlath!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[puneetlath]

@Santhosh-Sellavel please apply to the upwork job as well.

[Santhosh-Sellavel]

Sure will submit, Also will make a PR in a couple of days @puneetlath

[mananjadhav]

I don't think we need C+ review on this as @Santhosh-Sellavel is a part of C+ team working on the PR.

[puneetlath]

@mananjadhav @Santhosh-Sellavel as discussed here, let's go ahead and do the C+ review going forward, even if the PR submitter is a C+ themselves.

[Santhosh-Sellavel]

PR is merged and waiting for deployment!

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[mananjadhav]

@mvtglobally quick question for my knowledge. These KI Tests are performed on staging or some other environment?

[mvtglobally]

Yes, we are running on Staging only once a week check.

[mananjadhav]

The reason I asked is because two issues mention not reproducible during KI retests and both of them are not merged yet. So I am wondering 🤔 how come they got resolved automagically

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.88-15 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Restricted for timezone for chat rooms #10337

If no regressions arise, payment will be issued on 2022-08-30. 🎊

[puneetlath]

@mananjadhav @Santhosh-Sellavel sent you both hiring offers for the job through Upwork. Please accept when you have a chance so we can pay this out. Thanks!

[mananjadhav]

Accepted @puneetlath

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[Santhosh-Sellavel]

Done @puneetlath

[puneetlath]

Paid!